Refactor/adding mutable state builder tests iv (cadence-workflow#5769)

Grinds out some tests for a fiddly function assignEventIDToBufferedEvents who's function it is is to increment the various counters and ensure that all buffered decision tasks have assigned IDs. Adds a few minor guards for the logging functions
neil-xie · Mar 11, 2024 · ce25878 · ce25878
1 parent 4d513c0
commit ce25878
Show file tree

Hide file tree

Showing 2 changed files with 616 additions and 12 deletions.
diff --git a/service/history/execution/mutable_state_builder.go b/service/history/execution/mutable_state_builder.go
@@ -299,6 +299,7 @@ func NewMutableStateBuilderWithVersionHistoriesWithEventV2(
 	return msBuilder
 }
 
+// todo (david.porter)
 func (e *mutableStateBuilder) CopyToPersistence() *persistence.WorkflowMutableState {
 	state := &persistence.WorkflowMutableState{}
 
@@ -4811,24 +4812,30 @@ func (e *mutableStateBuilder) unixNanoToTime(
 }
 
 func (e *mutableStateBuilder) logInfo(msg string, tags ...tag.Tag) {
-	tags = append(tags, tag.WorkflowID(e.executionInfo.WorkflowID))
-	tags = append(tags, tag.WorkflowRunID(e.executionInfo.RunID))
-	tags = append(tags, tag.WorkflowDomainID(e.executionInfo.DomainID))
-	e.logger.Info(msg, tags...)
+	if e != nil && e.executionInfo != nil {
+		tags = append(tags, tag.WorkflowID(e.executionInfo.WorkflowID))
+		tags = append(tags, tag.WorkflowRunID(e.executionInfo.RunID))
+		tags = append(tags, tag.WorkflowDomainID(e.executionInfo.DomainID))
+		e.logger.Info(msg, tags...)
+	}
 }
 
 func (e *mutableStateBuilder) logWarn(msg string, tags ...tag.Tag) {
-	tags = append(tags, tag.WorkflowID(e.executionInfo.WorkflowID))
-	tags = append(tags, tag.WorkflowRunID(e.executionInfo.RunID))
-	tags = append(tags, tag.WorkflowDomainID(e.executionInfo.DomainID))
-	e.logger.Warn(msg, tags...)
+	if e != nil && e.executionInfo != nil {
+		tags = append(tags, tag.WorkflowID(e.executionInfo.WorkflowID))
+		tags = append(tags, tag.WorkflowRunID(e.executionInfo.RunID))
+		tags = append(tags, tag.WorkflowDomainID(e.executionInfo.DomainID))
+		e.logger.Warn(msg, tags...)
+	}
 }
 
 func (e *mutableStateBuilder) logError(msg string, tags ...tag.Tag) {
-	tags = append(tags, tag.WorkflowID(e.executionInfo.WorkflowID))
-	tags = append(tags, tag.WorkflowRunID(e.executionInfo.RunID))
-	tags = append(tags, tag.WorkflowDomainID(e.executionInfo.DomainID))
-	e.logger.Error(msg, tags...)
+	if e != nil && e.executionInfo != nil {
+		tags = append(tags, tag.WorkflowID(e.executionInfo.WorkflowID))
+		tags = append(tags, tag.WorkflowRunID(e.executionInfo.RunID))
+		tags = append(tags, tag.WorkflowDomainID(e.executionInfo.DomainID))
+		e.logger.Error(msg, tags...)
+	}
 }
 
 func (e *mutableStateBuilder) logDataInconsistency() {