Fix rubocop issues #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of changing the method arguments passed to a function, actually call the function properly. This keeps the code functioning in exactly the same fashion as it was previously, yet updates style to conform to rubocop's update of the SymbolProc cop.
Setting the `platform` configuration option _will_ break things. Provisioner options are generally set at the global level, and if a developer has multiple suites of differing platforms, this will cause things to break. By inheriting the `Configurable` module from test-kitchen we are able to read the platform name for each test suite's platform correctly. This will even read the platform correctly if `.kitchen.yml` only has one test suite but multiple platforms defined. I can't think of a solid case where the `platform` configuration option would need to be set specifically different from the default.
|
I think it is always good that people can override the config. There might be a case when we incorrectly determine the platform so giving option to override is good. |
|
@grubernaut with which version of rubocop do you hit this SymbolProc offense ? I can't reproduce with |
|
|
|
Ok, so styling issues aside, i'm not sure if we should remove flexibility of overriding something for no real reason... I can imagine overriding puppet platforms:
- name: platform1
provisioner:
platform: debian
- name: platform2
provisioner:
platform: redhat |
|
Ah I can see that use case if the platform name is custom. Good point |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of changing the method arguments passed to a function, actually
call the function properly. This keeps the code functioning in exactly
the same fashion as it was previously, yet updates style to conform to
rubocop's update of the SymbolProc cop.
Setting the
platformconfiguration option will breakthings. Provisioner options are generally set at the global level, and
if a developer has multiple suites of differing platforms, this will
cause things to break. By inheriting the
Configurablemodule fromtest-kitchen we are able to read the platform name for each test suite's
platform correctly. This will even read the platform correctly if
.kitchen.ymlonly has one test suite but multiple platforms defined.I can't think of a solid case where the
platformconfiguration optionwould need to be set specifically different from the default.