implement colorization for encoding.TextMarshaler #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes (resolves #20)
TextMarshaler
field toColors
, defaulting to the same color asString
TextMarshaler
color inencoder.encodeTextMarshaler
null
encoding inencodeTextMarshaler
to use null color, like other encoder functionsfatihcolor.Colors
with newTextMarshaler
field to matchjsoncolor.Colors
TestEncode_TextMarshaler
to confirm that the color is applied properlyI believe I've gone through every use of
Colors
and made sure that it accounts for the new field. All tests pass on my machine.One consideration in making
TextMarshaler
default to the same color asString
is that this changes the behavior of the library: such values would previously have no color, but will now be colored as strings. However, I think this is more in line with the expected behavior, and since these are separate fields, users can still customize them separately as they wish.