Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoinstall goimports #2

Merged
merged 3 commits into from
Dec 20, 2024

Conversation

PXshadow
Copy link
Contributor

Autoinstall at macro init time goimports if not already defined

Copy link
Owner

@neimanpinchas neimanpinchas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing this will streamline the path for newcomers, I sought this conveniance in your great hx2go project.

Phereps you want to remove the if (true|| on CompilerInit line 48.

Thank you

@neimanpinchas neimanpinchas merged commit c81a68e into neimanpinchas:main Dec 20, 2024
@PXshadow
Copy link
Contributor Author

Yeah I do want to remove the line 48 part in CompilerInit good catch, sorry I meant to remove that, it was just for testing.

@neimanpinchas
Copy link
Owner

I think #4 of the roadmap is already done, except of the main creation part.

I think maybe it belongs anyway go into a seperate step.

@elliott5
Copy link

elliott5 commented Dec 20, 2024

I think making a main.go file should be optional (though maybe the default, if one does not exist already), as the user may have an existing go system that (s)he wants to augment with existing haxe code.

Also, once a haxe system has been translated to go, it is likely that extra go code will be written to augment it, that extra code is likely to be referenced from main.go, if only to allow for correct initialisation. Therefore auto-overwriting would be a bad idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants