Merge pull request #9183 from neinteractiveliterature/empty-the-lint-…

…trap Upgrade to eslint 9; enable warnings for untranslated strings
neinteractiveliterature · Jul 10, 2024 · 5ce714d · 5ce714d
2 parents f1cdd4b + 8d33362
commit 5ce714d
Show file tree

Hide file tree

Showing 83 changed files with 691 additions and 545 deletions.
diff --git a/.codeclimate.yml b/.codeclimate.yml
diff --git a/.eslintignore b/.eslintignore
diff --git a/.eslintrc.cjs b/.eslintrc.cjs
diff --git a/.github/workflows/static.yml b/.github/workflows/static.yml
@@ -54,4 +54,4 @@ jobs:
  - uses: reviewdog/action-eslint@v1
  with:
  github_token: ${{ secrets.GITHUB_TOKEN }}
- eslint_flags: 'app/javascript test/javascript schema.graphql --ext .js,.jsx,.ts,.tsx,.gql,.graphql'
+ eslint_flags: 'app/javascript test/javascript schema.graphql'
diff --git a/app/graphql/graphql_operations_generated.json b/app/graphql/graphql_operations_generated.json
diff --git a/app/javascript/BuiltInFormControls/ArrayEditor.tsx b/app/javascript/BuiltInFormControls/ArrayEditor.tsx
@@ -49,7 +49,7 @@ function ArrayEditor<T>({
 
  <ul className="list-group list-group-flush">
  {array.map((value, index) => (
- // eslint-disable-next-line react/no-array-index-key
+  
  <li className="list-group-item" key={index}>
  <div className="d-flex">
  <div className="flex-grow-1">{renderValue(value)}</div>

diff --git a/app/javascript/BuiltInFormControls/CommitableInput.tsx b/app/javascript/BuiltInFormControls/CommitableInput.tsx
@@ -1,6 +1,7 @@
 import { useState, useCallback, useRef, ReactNode, InputHTMLAttributes } from 'react';
 import * as React from 'react';
 import classNames from 'classnames';
+import { useTranslation } from 'react-i18next';
 
 type CommitableInputChangeHandler = React.Dispatch<string> | ((value: string) => Promise<void>);
 
@@ -33,6 +34,7 @@ function CommitableInput({
  const [editingValue, setEditingValue] = useState<string | undefined>('');
  const [commitInProgress, setCommitInProgress] = useState(false);
  const inputRef = useRef<HTMLInputElement>();
+ const { t } = useTranslation();
 
  const beginEditing = useCallback(() => {
  setEditing(true);
@@ -159,10 +161,9 @@ function CommitableInput({
  onChange('');
  }}
  disabled={disabled || !value}
+ aria-label={t('buttons.clear')}
  >
- <i className="bi-x-square-fill">
- <span className="visually-hidden">Clear</span>
- </i>
+ <i className="bi-x-square-fill" />
  </button>
  ) : null}
  </div>

diff --git a/app/javascript/BuiltInFormControls/LiquidInput.tsx b/app/javascript/BuiltInFormControls/LiquidInput.tsx
@@ -9,7 +9,7 @@ import {
  CodeInput,
  useStandardCodeMirror,
  UseStandardCodeMirrorExtensionsOptions,
- // eslint-disable-next-line @typescript-eslint/no-unused-vars
+  
  liquid,
  LoadQueryWrapper,
 } from '@neinteractiveliterature/litform';
@@ -171,8 +171,10 @@ function LiquidInput(props: LiquidInputProps): JSX.Element {
  className="btn btn-link btn-sm me-3 text-body"
  style={{ cursor: 'pointer' }}
  onClick={() => setShowingDocs(false)}
+ title={t('buttons.close')}
+ aria-label={t('buttons.close')}
  >
- <i className="bi-x" title={t('buttons.close')} />
+ <i className="bi-x" />
  </button>
  </div>
  </header>

diff --git a/app/javascript/BuiltInFormControls/ScheduledValueEditor.tsx b/app/javascript/BuiltInFormControls/ScheduledValueEditor.tsx
@@ -209,7 +209,7 @@ function ScheduledValueEditor<ValueType>({
  <ScheduledValueTimespanRow
  timespan={timespan}
  timezone={timezone}
- key={i} // eslint-disable-line react/no-array-index-key
+ key={i}  
  rowIdentifier={i}
  deleteClicked={deleteRowClicked}
  finishDidChange={timespanFinishDidChange}

diff --git a/app/javascript/BuiltInFormControls/TimezoneSelect.tsx b/app/javascript/BuiltInFormControls/TimezoneSelect.tsx
@@ -1,4 +1,4 @@
-/* eslint-disable jsx-a11y/label-has-for */
+ 
 
 import { useState, useMemo, ReactNode, SetStateAction, useId } from 'react';
 

diff --git a/app/javascript/CmsAdmin/CmsContentGroupsAdmin/queries.graphql b/app/javascript/CmsAdmin/CmsContentGroupsAdmin/queries.graphql
@@ -1,7 +1,7 @@
 #import "../../Permissions/fragments.graphql"
 
 fragment CmsContentFields on CmsContent {
- # eslint-disable-next-line @graphql-eslint/naming-convention
+  
  __typename
 
  ... on Page {

diff --git a/app/javascript/CmsAdmin/CmsFilesAdmin/index.tsx b/app/javascript/CmsAdmin/CmsFilesAdmin/index.tsx
@@ -75,6 +75,7 @@ export default LoadQueryWrapper(useCmsFilesAdminQuery, function CmsFilesAdmin({
  renderError: (deleteError) => <ErrorDisplay graphQLError={deleteError} />,
  })
  }
+ aria-label={t('buttons.delete')}
  >
  <i className="bi-trash-fill" aria-hidden="true" />
  </button>
@@ -95,7 +96,7 @@ export default LoadQueryWrapper(useCmsFilesAdminQuery, function CmsFilesAdmin({
  />
  </div>
  <div className="card-body text-center py-2">
- <a href={cmsFile.file.url}>
+ <a href={cmsFile.file.url} aria-label={cmsFile.file.filename}>
  <FilePreview
  url={cmsFile.file.thumbnailUrl}
  contentType={cmsFile.file.content_type}