Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keys to user keyring instead of session keyring #15

Closed
wants to merge 1 commit into from
Closed

Add keys to user keyring instead of session keyring #15

wants to merge 1 commit into from

Conversation

seebaclo
Copy link
Contributor

@seebaclo seebaclo commented Apr 21, 2017

As discussed in #14 . It fixes systemd setups. I tested this and it works as expected. I don't see any drawbacks of switching to user keyring. It's linked to session keyring by pam_keyinit automatically.

As discussed in #14 . It fixes systemd setups. I tested this and it works as expected. I don't see any drawbacks of switching to user keyring. It could be linked to session keyring by pam_keyinit
@neithernut
Copy link
Owner

Making the keyring used selectable would be acceptable. Switching the keys for all and every user is not. Especially if it's just for the sake of a systemd-use-case. Hence, I'll close this PR.
However, I'll probably have the time to push a PR for making the keyring settable through an option next week. Sadly, I'll probably still don't have a good setup for automated tests by then.

@neithernut neithernut closed this Apr 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants