Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows DV7toDV8.sh script to work on non-Mac hardware #14

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

ajyey
Copy link

@ajyey ajyey commented Mar 27, 2024

This MR allows the script to run on non-mac hardware.

My home media server runs on Linux and I do most of my work there, so being able to run this on Linux seemed like it would also be helpful for other users.

This MR:

  • Adds support for additional command line arguments
  • Updates the README to reflect those arguments
  • Slightly rewords some things in the README
  • Only prompts the user for language codes via applescript if the user is running on a Mac and they have not passed in the language codes via command line argument

@ajyey
Copy link
Author

ajyey commented Apr 4, 2024

@nekno thoughts?

Copy link
Owner

@nekno nekno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ajyey! Thanks for your patience (while I've been traveling) and these contributions!

I've requested some changes for you to approve/make while I test out these changes on macOS.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/DV7toDV8.sh Outdated Show resolved Hide resolved
src/DV7toDV8.sh Outdated Show resolved Hide resolved
src/DV7toDV8.sh Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/DV7toDV8.sh Outdated
Comment on lines 66 to 67
*) # preserve positional arguments
PARAMS="$PARAMS $1"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless you're moving the script or the mkv files into the same folder each time, the one required param for the script has been the target directory.

It's perfectly fine to support that use case, but what do you think about defaulting to the present working directory (as you've done) but then setting targetDir here, as the one unlabeled argument, rather than using the -t/--target label?

I think it's more common that you wouldn't be moving the files around, the script will have a home and your working files will be in different folders each time, so I think using an unlabeled arg for the target directory makes the most sense.

If -t/--target were to be required, then we'd need to update the Platypus app config file to reflect this change in the script as part of this PR.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. Let me know what you think 👍

@THX723 THX723 mentioned this pull request Jun 8, 2024
@nekno nekno assigned nekno and ajyey and unassigned nekno Jun 8, 2024
ajyey and others added 3 commits June 10, 2024 20:54
Co-authored-by: nekno <nekno@users.noreply.github.com>
Co-authored-by: nekno <nekno@users.noreply.github.com>
@ajyey ajyey requested a review from nekno June 12, 2024 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants