LGTM画像になる前の一時的な画像を扱う為のS3バケットを作成 #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issueURL
#12
Doneの定義
変更点概要
表題の通り、LGTM画像になる前の一時的な画像を扱う為のS3バケットを作成。
名前は
prod-lgtmeow-upload-images、このS3バケットには以下の3つのディレクトリを作成してある。lgtm-imagesディレクトリに格納されたLGTM画像は https://github.com/nekochans/convert-to-webp によってWebpに変換され、現在画像配信に利用しているprod-lgtmeow-imagesに移動される。その後、nekochans/lgtm-cat-lambda#3 で作成されるLambda関数によってRDSに必要な情報が記録される。レビュアーに重点的にチェックして欲しい点
ディレクトリ名とその役割、画像がアップロードされてから、最終的にLGTM画像として配信されるまでの流れに関して問題ないか確認をしてもらえるとありがたい:pray: