S3バケットのオブジェクトに有効期限を設定するルールを追加 #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issueURL
#24
Doneの定義
変更点概要
バージョニングが無効になっているS3バケットに対してオブジェクトの有効期限を設定。
これによって永続化が不要な画像ファイルは有効期限が来たら自動的に削除されるようになった。
検証用に
stg-lgtmeow-upload-imagesにtest/test-cat1.pngを追加。この画像が以下のようになっているので、設定は問題なく出来ている認識。
レビュアーに重点的にチェックして欲しい点
期待する動作としては、有効期限が過ぎたオブジェクトはS3バケットから完全に削除されて欲しいんだけど、設定方法がこれで合っているか確認してもらえると:pray: