LGTM画像を配信する為のCDNを作成 #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keitakn
commented
Feb 24, 2021
Comment on lines
+1
to
+15
| output "ap_northeast_1_main_domain_acm_arn" { | ||
| value = module.ap_northeast_1_acm.main_domain_acm_arn | ||
| } | ||
|
|
||
| output "ap_northeast_1_sub_domain_acm_arn" { | ||
| value = module.ap_northeast_1_acm.sub_domain_acm_arn | ||
| } | ||
|
|
||
| output "us_east_1_main_domain_acm_arn" { | ||
| value = module.us_east_1_acm.main_domain_acm_arn | ||
| } | ||
|
|
||
| output "us_east_1_sub_domain_acm_arn" { | ||
| value = module.us_east_1_acm.sub_domain_acm_arn | ||
| } |
There was a problem hiding this comment.
us_east_1_sub_domain_acm_arn のみ今回利用している、
ap_northeast_1_sub_domain_acm_arn は後でAPIサーバーが出来た際に利用するだろうけど、他はいらなかったかも・・・🐱
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issueURL
#3
関連URL
画像サーバーの動作確認用のURL
https://lgtm-images.lgtmeow.com/test/1.jpg
https://lgtm-images.lgtmeow.com/test/2.jpg
https://lgtm-images.lgtmeow.com/test/3.jpg
https://lgtm-images.lgtmeow.com/test/3.webp
Doneの定義
変更点概要
ACMの証明書とCloudFrontを追加。
以下のURLでテスト画像を用意し閲覧出来る事を確認。
https://lgtm-images.lgtmeow.com/test/1.jpg
https://lgtm-images.lgtmeow.com/test/2.jpg
webp形式の画像も問題なく配信出来ることを確認。
https://lgtm-images.lgtmeow.com/test/3.jpg （こっちが3.webpの元画像）
https://lgtm-images.lgtmeow.com/test/3.webp
補足情報
webpへの変換は以下のブログを参考に行った。
https://blog.ideamans.com/2020/08/webp-params-2020.html
手順としては以下を実行するだけ。
cwebpに関しては こちらの手順 でインストール可能。元々1.4MBあった画像が363KBまで落ちているので、配信フォーマットを
.webp形式にするのは一定の効果がありそう。