ねこ画像と判定された元画像は永続的に残すように変更 #49
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobayashi-m42
approved these changes
Nov 13, 2021
|
@kobayashi-m42 レビューありがとう🐱
なるほど確かにこの画像は基本的に一度だけ保存される物だからバージョニングは必要ないかもね！ 今回バージョニングを有効にしたのは、永続的に残したい画像だから、何か手違いがあって画像を上書きしてしまったり、削除してしまった際に戻せるようにしておこうかなという理由もあった感じだよ！ 設定見直しする場合は |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issueURL
#48
Doneの定義
変更点概要
今後画像を作り直す可能性もあるので、ねこ画像と判定された画像は永続的に残すようにする為、versioningを有効化。
この設定は現状LGTM画像を配信している
lgtm_images_bucketと同じ設定。