Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terraform-init.sh のディレクトリ一覧をshell内部で取得するように変更 #71

Merged
merged 1 commit into from
Mar 27, 2022

Conversation

kobayashi-m42
Copy link
Member

issueURL

#70

Doneの定義

#70 の完了の定義が満たされていること

変更点概要

terraform-init.sh のディレクトリ一覧をshell内部で取得するように変更。

作業ディレクトリを追加した際に terraform-init.sh の更新をよく忘れてしまうので、terraform-init.sh を更新しなくていいように変更を行った。また、ディレクトリ構成が大きく変わることはなさそうなので、正規表現で取得する形で問題ないかなと思ってこの形にしている。

@kobayashi-m42 kobayashi-m42 self-assigned this Mar 27, 2022
@kobayashi-m42 kobayashi-m42 requested a review from keitakn March 27, 2022 15:08
Copy link
Member

@keitakn keitakn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これは嬉しい変更だ👍

対応ありがとう🐱!

LGTMeow

@kobayashi-m42 kobayashi-m42 merged commit b64f410 into main Mar 27, 2022
@kobayashi-m42 kobayashi-m42 deleted the feature/issue70 branch March 27, 2022 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants