lgtm-cat-apiのAPIGatewayにCORSの設定を追加 #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 31, 2022
keitakn
added a commit
to nekochans/lgtm-cat-api-archived
that referenced
this pull request
Apr 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issueURL
#72
関連URL
なし
Doneの定義
変更点概要
https://docs.aws.amazon.com/ja_jp/apigateway/latest/developerguide/http-api-cors.html のドキュメントに従い、
OPTIONS /{proxy+}ルートを追加。API側の
OPTIONSルートの設定はgithub.com/go-chi/corsを利用するようにした。対応PRは https://github.com/nekochans/lgtm-cat-api/pull/34理由としてはローカル環境から将来的に作成されるであろう lgtm-cat-apiのローカルサーバーに通信する可能性もある為、そこでCORSのHeaderが設定されていないと結合して動作確認する際に不都合が発生すると判断した為。
レビュアーに重点的にチェックして欲しい点
関連PRを含めて方針問題ないか確認してもらえると:pray:
補足情報
本件は nekochans/lgtm-cat-frontend#146 の解決の為に実施している。