Route 53のTXTレコードを管理する為のModuleを追加 #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobayashi-m42
approved these changes
Mar 6, 2021
|
コメントありがとう🐱
#11 を作ったからここで一旦全部見直そうと思う👌 このPRは一旦マージするね:cat2: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issueURL
#6
Doneの定義
変更点概要
13-txtを追加して、TXTレコードを管理出来るようにした。TXTレコードはフロントエンドでもバックエンドでも利用する可能性があるので、別のtfstateとして独立させたほうが良いと判断した。
レビュアーに重点的にチェックして欲しい点
13-txtの名前でもっと良い案があれば教えて欲しい:pray:補足情報
Google Search Consoleは利用可能になっており、XMLサイトマップのURLも送信済。