Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] add extraEnvVars to Model Inferencing Server #16

Closed
hayone1 opened this issue Nov 3, 2024 · 2 comments
Closed

[Feature] add extraEnvVars to Model Inferencing Server #16

hayone1 opened this issue Nov 3, 2024 · 2 comments
Assignees
@nekomeowww
Labels
enhancement New feature or request

Comments

@hayone1
Copy link

hayone1 commented Nov 3, 2024

I'm working in an airtight environment that needs proxy env vars to access the internet. Being able to add those as envvars would be nice.
@nekomeowww nekomeowww added the enhancement New feature or request label Nov 4, 2024
@nekomeowww nekomeowww self-assigned this Nov 4, 2024
@nekomeowww
Copy link
Owner

Let me just add the entire pod template so that everyone can tweak the settings on your own.

nekomeowww added a commit that referenced this issue Nov 9, 2024
@nekomeowww
feat: refactors, added new extraEnvVar, extraEnvFrom, `runtimeCla…
d043ea9 
…ssName` and `podTemplate` for Model CRD, fixes

- Refactored controller with new wrappers and utilities
- Fixed curl not working in the container
- Added new fields `extraEnvVar`, `extraEnvFrom`, `runtimeClassName` and `podTemplate` for Model CRD

Close #15, #16, #17

Signed-off-by: Neko Ayaka <neko@ayaka.moe>
@nekomeowww nekomeowww mentioned this issue Nov 9, 2024
Merged
nekomeowww added a commit that referenced this issue Nov 9, 2024
@nekomeowww
feat: refactors, added new extraEnvVar, extraEnvFrom, `runtimeCla…
daf69f3 
…ssName` and `podTemplate` for Model CRD, fixes (#18)

- Refactored controller with new wrappers and utilities
- Fixed curl not working in the container
- Added new fields `extraEnvVar`, `extraEnvFrom`, `runtimeClassName` and `podTemplate` for Model CRD

Close #15, #16, #17

Signed-off-by: Neko Ayaka <neko@ayaka.moe>
@nekomeowww
Copy link
Owner

Implemented, extraEnvVar, extraEnvFrom were added. Released as v0.10.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nekomeowww nekomeowww

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nekomeowww @hayone1