Skip to content

Commit

Permalink
fix all nolint uses
Browse files Browse the repository at this point in the history
  • Loading branch information
alex-savchuk committed Sep 17, 2022
1 parent e67ad82 commit 16583b0
Show file tree
Hide file tree
Showing 7 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion pkg/common/git/git.go
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,7 @@ func gitOptions(token string) (fetchOptions git.FetchOptions, pullOptions git.Pu
}

// NewGitCloneExecutor creates an executor to clone git repos
// nolint:gocyclo
//nolint:gocyclo
func NewGitCloneExecutor(input NewGitCloneExecutorInput) common.Executor {
return func(ctx context.Context) error {
logger := common.Logger(ctx)
Expand Down
2 changes: 1 addition & 1 deletion pkg/container/docker_cli.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// nolint: unparam
//nolint:unparam
package container

// exact copy of https://github.com/docker/cli/blob/9ac8584acfd501c3f4da0e845e3a40ed15c85041/cli/command/container/opts.go
Expand Down
2 changes: 1 addition & 1 deletion pkg/container/file_collector.go
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ func (*defaultFs) Readlink(path string) (string, error) {
return os.Readlink(path)
}

// nolint: gocyclo
//nolint:gocyclo
func (fc *fileCollector) collectFiles(ctx context.Context, submodulePath []string) filepath.WalkFunc {
i, _ := fc.Fs.OpenGitIndex(path.Join(fc.SrcPath, path.Join(submodulePath...)))
return func(file string, fi os.FileInfo, err error) error {
Expand Down
2 changes: 1 addition & 1 deletion pkg/exprparser/interpreter.go
Original file line number Diff line number Diff line change
Expand Up @@ -557,7 +557,7 @@ func (impl *interperterImpl) evaluateLogicalCompare(compareNode *actionlint.Logi
return nil, fmt.Errorf("Unable to compare incompatibles types '%s' and '%s'", leftValue.Kind(), rightValue.Kind())
}

// nolint:gocyclo
//nolint:gocyclo
func (impl *interperterImpl) evaluateFuncCall(funcCallNode *actionlint.FuncCallNode) (interface{}, error) {
args := make([]reflect.Value, 0)

Expand Down
2 changes: 1 addition & 1 deletion pkg/model/planner.go
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ type WorkflowFiles struct {
}

// NewWorkflowPlanner will load a specific workflow, all workflows from a directory or all workflows from a directory and its subdirectories
// nolint: gocyclo
//nolint:gocyclo
func NewWorkflowPlanner(path string, noWorkflowRecurse bool) (WorkflowPlanner, error) {
path, err := filepath.Abs(path)
if err != nil {
Expand Down
2 changes: 1 addition & 1 deletion pkg/model/workflow.go
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ func (j *Job) Matrix() map[string][]interface{} {

// GetMatrixes returns the matrix cross product
// It skips includes and hard fails excludes for non-existing keys
// nolint:gocyclo
//nolint:gocyclo
func (j *Job) GetMatrixes() []map[string]interface{} {
matrixes := make([]map[string]interface{}, 0)
if j.Strategy != nil {
Expand Down
2 changes: 1 addition & 1 deletion pkg/runner/action.go
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ func removeGitIgnore(ctx context.Context, directory string) error {
}

// TODO: break out parts of function to reduce complexicity
// nolint:gocyclo
//nolint:gocyclo
func execAsDocker(ctx context.Context, step actionStep, actionName string, basedir string, localAction bool) error {
logger := common.Logger(ctx)
rc := step.getRunContext()
Expand Down

0 comments on commit 16583b0

Please sign in to comment.