Problems with skipping non-existing includes keys

[ziyue-pan]

#763 Introduced an fix (skip non-existing includes keys and hard fail on non-existing excludes keys), which seems to behave differently with GitHub Actions. GitHub Actions allow non-existing includes keys in matrix product (check this run defined by this configuration)

I reproduced it through debugging with act's source code v0.2.25 and the above configuration file.

System information

• Operating System: Linux
• Architecture: x64 (64-bit)
• Docker version: 20.10.12
• Docker image used in act: did not actually execute the CI process, just parse the configuration file
• act version: 0.2.25

Expected behaviour

  conda:
    name: conda
    runs-on: ${{matrix.os}}-latest
    strategy:
      fail-fast: false
      matrix:
        include:
          - {os: ubuntu, version: 1.8.16, channel: conda-forge, rust: stable}
          - {os: windows, version: 1.8.17, channel: conda-forge, rust: stable}
          - {os: macos, version: 1.8.18, channel: anaconda, rust: stable}
          - {os: ubuntu, version: 1.8.20, channel: anaconda, rust: beta}
          - {os: ubuntu, version: 1.10.1, channel: anaconda, rust: nightly}
...

GetMatrixes() is expected to return the matrix with multiple sets.

Actual behaviour

GetMatrixes() returns []

Workflow and/or repository

https://github.com/aldanor/hdf5-rust/blob/master/.github/workflows/ci.yml

act output

No log is printed. I built act from the source code.

More

One possible workaround for this is to remove the non-existing keys check. Yet my solution may not be sound enough.

@@ -252,12 +252,7 @@ func (j *Job) GetMatrixes() []map[string]interface{} {
 					}
 				case interface{}:
 					v := v.(map[string]interface{})
-					for k := range v {
-						if _, ok := m[k]; ok {
-							includes = append(includes, v)
-							break
-						}
-					}
+					includes = append(includes, v)
 				}
 			}
 			delete(m, "include")

[catthehacker]

duplicate of #769