-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify Matrix decode, add defaults for fail-fast and max-parallel, add test #763
Conversation
This comment has been minimized.
This comment has been minimized.
46d6a81
to
795cbfc
Compare
Codecov Report
@@ Coverage Diff @@
## master #763 +/- ##
==========================================
+ Coverage 49.27% 53.49% +4.22%
==========================================
Files 23 23
Lines 2401 2658 +257
==========================================
+ Hits 1183 1422 +239
+ Misses 1090 1087 -3
- Partials 128 149 +21
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
895b1f1
to
4adc773
Compare
This comment has been minimized.
This comment has been minimized.
4adc773
to
4942212
Compare
GitHub doesn't appear to do that. strategy:
matrix:
python-version: [3.6, 3.7, 3.8, 3.9]
is-master-or-staging:
- ${{ github.ref == 'refs/heads/master' || github.ref == 'refs/heads/staging' }}
exclude:
- python-version: 3.8
is-master-or-staging: false
- python-version: 3.9
is-master-or-staging: false |
This comment has been minimized.
This comment has been minimized.
Could you share a link to that workflow and/or your |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Your example has defined all required keys in matrix so that's why it's not failing |
Ah, I misunderstood "non-existing excludes" as "excludes not existing in the cross product". Thanks for the clarification and your good work! |
fix[workflow]: default `max-parallel` fix[workflow]: default `fail-fast`, it's `true`, not `false` fix[workflow]: skipping over the job when `strategy:` is defined but `matrix:` isn't (fixes nektos#625) fix[workflow]: skip non-existing includes keys and hard fail on non-existing excludes keys fix[workflow]: simplify Matrix decode (because I "think" I know how `yaml` works) (fixes nektos#760) fix[tests]: add test for planner and runner
4942212
to
aa0d7b5
Compare
updated commit description to mention that it's for keys |
fix[workflow]: default
max-parallel
fix[workflow]: default
fail-fast
, it'strue
, notfalse
fix[workflow]: skipping over the job when
strategy:
is defined butmatrix:
isn't (fixes #625)fix[workflow]: skip non-existing includes keys and hard fail on non-existing excludes keys
fix[workflow]: simplify Matrix decode (because I "think" I know how
yaml
works) (fixes #760)fix[tests]: add test for planner and runner