Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Ability to install act package into Windows OS (via winget for example). #1146

Closed
omonimus1 opened this issue May 1, 2022 · 9 comments · Fixed by #1623
Closed
Labels
kind/feature-request New feature or request

Comments

@omonimus1
Copy link

Describe feature

It would be great to download and use this package into Windows OS.
Distribute it via winget (official windows package manager) will allow more developers to use act.

In terms of advertisement, it would be great also from the https://formulae.brew.sh/formula/act#default redirect to winget for windows user (as many tutorials about act already redirect directly to brew page).

@omonimus1 omonimus1 added the kind/feature-request New feature or request label May 1, 2022
@catthehacker
Copy link
Member

catthehacker commented May 2, 2022

Distribute it via winget (official windows package manager) will allow more developers to use act.

winget (https://github.com/microsoft/winget-cli | https://github.com/microsoft/winget-pkgs) requires packages to be self-executable installers, we don't have one and most likely won't have for a long time as goreleaser doesn't support this type of artefacts. It would also require us to sign the artefacts with a trusted certificate so Windows won't complain.

Requires: microsoft/winget-cli#140

In terms of advertisement, it would be great also from the formulae.brew.sh/formula/act#default redirect to winget for windows user (as many tutorials about act already redirect directly to brew page).

Don't think that is possible nor that we should do that. Would be better to ask authors of said articles to point to our README / installation page in Wiki.

@alanlivio
Copy link

It is a very interesting feature.

@phillip-haydon
Copy link

@catthehacker it looks like issue 140 was merged and closed in September. Could this now be added to winget?

@Arthapz
Copy link

Arthapz commented Jan 13, 2023

microsoft/winget-pkgs#93675 i've done a PR, maybe need some reviewing (for publishers URLs)

@Arthapz
Copy link

Arthapz commented Jan 13, 2023

ah the package is done, but they can't merge it because of microsoft/winget-pkgs#87300
they'll merge it when it's done

so it's let a lot of time for reviewing the meta-infos https://github.com/microsoft/winget-pkgs/pull/93675/files#diff-b8e3d9e7cc98ed3ac1070cb7663345f48849ff77d7bfe978b5424890c52e091f

@sitiom
Copy link
Contributor

sitiom commented Feb 1, 2023

microsoft/winget-pkgs#93675 i've done a PR, maybe need some reviewing (for publishers URLs)

@Arthapz Please check my review on your PR.

Also, once the PR is merged, Winget Releaser would have to be set up in this repo for automatic package updates.

@Arthapz
Copy link

Arthapz commented Feb 2, 2023

done

@Arthapz
Copy link

Arthapz commented Feb 10, 2023

My PR has been merged onto winget, act should be be installable by winget now

@sitiom
Copy link
Contributor

sitiom commented Feb 10, 2023

The Winget package is currently outdated, and there is a blocking issue for Winget Releaser: vedantmgoyal9/winget-releaser#82. Will PR the releaser workflow once that is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature-request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants