Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add Winget installation instructions #1622

Merged
merged 1 commit into from
Feb 11, 2023
Merged

chore: add Winget installation instructions #1622

merged 1 commit into from
Feb 11, 2023

Conversation

sitiom
Copy link
Contributor

@sitiom sitiom commented Feb 10, 2023

The Winget package is currently outdated, and there is a blocking issue for Winget Releaser: vedantmgoyal9/winget-releaser#82. Will PR the releaser workflow once that is resolved.

@sitiom sitiom requested a review from a team as a code owner February 10, 2023 15:56
@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Merging #1622 (de95b4e) into master (4989f44) will increase coverage by 0.69%.
The diff coverage is 75.63%.

@@            Coverage Diff             @@
##           master    #1622      +/-   ##
==========================================
+ Coverage   61.22%   61.92%   +0.69%     
==========================================
  Files          46       46              
  Lines        7141     7248     +107     
==========================================
+ Hits         4372     4488     +116     
+ Misses       2462     2457       -5     
+ Partials      307      303       -4     
Impacted Files Coverage Δ
pkg/container/docker_cli.go 82.23% <ø> (ø)
pkg/container/docker_logger.go 52.08% <ø> (ø)
pkg/container/docker_pull.go 33.33% <ø> (ø)
pkg/container/docker_run.go 13.58% <ø> (ø)
pkg/container/docker_volume.go 0.00% <ø> (ø)
pkg/container/docker_images.go 27.02% <29.41%> (-4.13%) ⬇️
pkg/model/github_context.go 61.06% <32.00%> (-19.40%) ⬇️
pkg/container/docker_auth.go 51.35% <56.25%> (+3.73%) ⬆️
pkg/runner/runner.go 86.45% <66.66%> (-2.05%) ⬇️
pkg/runner/step.go 83.33% <75.00%> (+0.36%) ⬆️
... and 19 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cplee
Copy link
Contributor

cplee commented Feb 10, 2023

Thanks for the PR. Im good with this but one question before merging...is one of the Windows package managers (chocolatey, scoop, winget) emerging as the winner? Will we always need to support all 3?

@sitiom
Copy link
Contributor Author

sitiom commented Feb 11, 2023

is one of the Windows package managers (chocolatey, scoop, winget) emerging as the winner?

Winget is the official package manager by Microsoft, so it will be here to stay. Because it is the official solution, it is inevitable that it will be commonly adopted by users. But I don't think Chocolatey and Scoop will go away either. They have already existed for years before Winget, and so most people are already dependent on them.

Will we always need to support all 3?

That depends on you. You don't have to worry about Scoop, though, as it has its own update mechanism on its own bucket.

@mergify mergify bot merged commit c378a7d into nektos:master Feb 11, 2023
@sitiom sitiom deleted the patch-1 branch February 12, 2023 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Duplicate] Consider publishing act to winget packages repository
2 participants