Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upload-artifacts/download-artifacts@v4 not working with large files #2371

Closed
ArendJan opened this issue Jun 20, 2024 · 2 comments · Fixed by #2402
Closed

upload-artifacts/download-artifacts@v4 not working with large files #2371

ArendJan opened this issue Jun 20, 2024 · 2 comments · Fixed by #2402
Labels
kind/bug Something isn't working

Comments

@ArendJan
Copy link

Bug report info

act version:            0.2.63
GOOS:                   linux
GOARCH:                 amd64
NumCPU:                 8
Docker host:            DOCKER_HOST environment variable is not set
Sockets found:
        /var/run/docker.sock
Config files:           
        /home/arendjan/.actrc:
                -P ubuntu-latest=catthehacker/ubuntu:act-latest
                -P ubuntu-22.04=catthehacker/ubuntu:act-22.04
                -P ubuntu-20.04=catthehacker/ubuntu:act-20.04
                -P ubuntu-18.04=catthehacker/ubuntu:act-18.04
Build info:
        Go version:            go1.21.10
        Module path:           github.com/nektos/act
        Main version:          (devel)
        Main path:             github.com/nektos/act
        Main checksum:         
        Build settings:
                -buildmode:           exe
                -compiler:            gc
                -ldflags:             -s -w -X main.version=0.2.63 -X main.commit=c959fdd58835195916386b44a87632151a1b491a -X main.date=2024-06-01T02:17:39Z -X main.builtBy=goreleaser
                CGO_ENABLED:          0
                GOARCH:               amd64
                GOOS:                 linux
                GOAMD64:              v1
                vcs:                  git
                vcs.revision:         c959fdd58835195916386b44a87632151a1b491a
                vcs.time:             2024-06-01T02:17:21Z
                vcs.modified:         false
Docker Engine:
        Engine version:        26.1.4
        Engine runtime:        runc
        Cgroup version:        1
        Cgroup driver:         cgroupfs
        Storage driver:        overlay2
        Registry URI:          https://index.docker.io/v1/
        OS:                    Ubuntu 20.04.6 LTS
        OS type:               linux
        OS version:            20.04
        OS arch:               x86_64
        OS kernel:             5.15.153.1-microsoft-standard-WSL2
        OS CPU:                8
        OS memory:             7810 MB
        Security options:
                name=seccomp,profile=builtin

Command used with act

act -v -j download_huge_file --artifact-server-path test/

Describe issue

When uploading/downloading 'large' files, the v4 artifact system does not work and results in ::debug::Failed to download artifact after 1 retries due to Not a valid zip file. Retrying in 5 seconds... and ::debug::response.message: Artifact download failed: Blob storage chunk did not respond in 30000ms messages.

It worked with the v3 actions.

Link to GitHub repository

No response

Workflow content

name: test

on:
    [push]

jobs:
    upload_huge_file:
        runs-on: ubuntu-latest
        steps:
            - uses: actions/checkout@v4
            # create huge file, works with /dev/null, as the zip is compressed
            - run: dd if=/dev/random of=huge_file bs=1M count=1024
            - name: Upload huge file
              uses: actions/upload-artifact@v4
              with:
                  name: huge_file
                  path: huge_file
    download_huge_file:
        runs-on: ubuntu-latest
        needs: upload_huge_file
        steps:
            - uses: actions/checkout@v4
            - name: Download huge file
              uses: actions/download-artifact@v4
              with:
                  name: huge_file
            - run: ls -al

Relevant log output

too long, uploaded to here: https://pastebin.com/Pv6eS2Eq

Additional information

No response

@ArendJan ArendJan added the kind/bug Something isn't working label Jun 20, 2024
facebook-github-bot pushed a commit to facebookresearch/ocean that referenced this issue Jun 26, 2024
Summary:
- Switch to v3 of upload/download to get around [nektos/act issue #2371](nektos/act#2371)
- Archive build directory before upload to preserve executable file permissions because tar preserves file permissions, but actions/download-artifact@v3 does not
- In composite action, include `shell: bash` in a step iff it has `run: `

Reviewed By: enpe

Differential Revision:
D59080244

Privacy Context Container: L1191897

fbshipit-source-id: 39a0e05132ef0f10c0cd41946dbbe124b67ecaa3
@ArendJan
Copy link
Author

ArendJan commented Jul 5, 2024

Probably the same issue as #2351

@VAllens
Copy link

VAllens commented Aug 9, 2024

Any progress?

@mergify mergify bot closed this as completed in #2402 Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants