feat: add step name to logger field

[KnisterPeter]

This change does add the step name to the logger fields. This does
not change the output for our users, but for the json logger, it
does make each step output traceable.

[codecov]

Codecov Report

Merging #1027 (002f989) into master (4f8da0a) will increase coverage by 1.26%.
The diff coverage is 80.55%.

@@            Coverage Diff             @@
##           master    #1027      +/-   ##
==========================================
+ Coverage   57.50%   58.77%   +1.26%     
==========================================
  Files          32       34       +2     
  Lines        4594     4655      +61     
==========================================
+ Hits         2642     2736      +94     
+ Misses       1729     1690      -39     
- Partials      223      229       +6     

Impacted Files	Coverage Δ
pkg/model/action.go	0.00% <ø> (ø)
pkg/model/planner.go	50.73% <ø> (+0.32%)	⬆️
pkg/exprparser/interpreter.go	74.39% <66.66%> (+0.99%)	⬆️
pkg/runner/logger.go	62.85% <67.56%> (-2.58%)	⬇️
pkg/runner/runner.go	74.52% <75.00%> (-1.95%)	⬇️
pkg/runner/expression.go	89.36% <77.61%> (-1.46%)	⬇️
pkg/runner/job_executor.go	82.50% <82.50%> (ø)
pkg/runner/step_context.go	85.81% <84.00%> (+4.17%)	⬆️
pkg/runner/action.go	84.21% <84.21%> (ø)
pkg/runner/run_context.go	80.03% <96.15%> (+0.38%)	⬆️
... and 9 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

[ChristopherHX]

This doesn't seem to work for me.
Also every step no longer prints via the job logger.

[KnisterPeter]

This doesn't seem to work for me.
Also every step no longer prints via the job logger.

Right, the step should log through the step-logger.
Do you use a different job-logger?

[ChristopherHX]

Do you use a different job-logger?

Yes I use a custom one, since I send the log to github actions service no logging to stdout.

[KnisterPeter]

So, the problem is that a different logger is used. Can't you set the output on the root logger? That should then be used by all context loggers and redirect as you wish

[ChristopherHX]

Can't you set the output on the root logger?

No, this PR overrides everything I set:

stepLogger.SetOutput(os.Stdout)

The other if case is always skipped during debugging of this PR

[KnisterPeter]

Since I don't know your code, I cannot even think of another way to do it. Can you reference your code lines here?

[ChristopherHX]

Can you reference your code lines here?

https://github.com/ChristopherHX/act/blob/cd5e0e29fd725880b4cf58f315f6c791450bf266/pkg/agent/main.go#L1570-L1587

here I set my custom logger before I call act https://github.com/ChristopherHX/act/blob/cd5e0e29fd725880b4cf58f315f6c791450bf266/pkg/agent/main.go#L1691

[mergify]

@KnisterPeter this pull request has failed checks 🛠

[ChristopherHX]

All fine now, I can confirm that you no longer notice the change without a json logger or a debugger.

[mergify]

@KnisterPeter this pull request is now in conflict 😩

[mergify]

@KnisterPeter this pull request has failed checks 🛠