Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert: Don't stop JobContainer on failure #1041

Merged

Conversation

ChristopherHX
Copy link
Contributor

This was a breaking change of nektos/act#840

@codecov
Copy link

codecov bot commented Mar 14, 2022

Codecov Report

Merging #1041 (a5f45a3) into master (4f8da0a) will increase coverage by 1.38%.
The diff coverage is 80.49%.

@@            Coverage Diff             @@
##           master    #1041      +/-   ##
==========================================
+ Coverage   57.50%   58.89%   +1.38%     
==========================================
  Files          32       33       +1     
  Lines        4594     4644      +50     
==========================================
+ Hits         2642     2735      +93     
+ Misses       1729     1681      -48     
- Partials      223      228       +5     
Impacted Files Coverage Δ
pkg/model/action.go 0.00% <ø> (ø)
pkg/model/planner.go 50.73% <ø> (+0.32%) ⬆️
pkg/exprparser/interpreter.go 74.39% <66.66%> (+0.99%) ⬆️
pkg/runner/logger.go 66.00% <67.56%> (+0.56%) ⬆️
pkg/runner/runner.go 74.52% <75.00%> (-1.95%) ⬇️
pkg/runner/expression.go 89.36% <77.61%> (-1.46%) ⬇️
pkg/runner/job_executor.go 82.05% <82.05%> (ø)
pkg/runner/step_context.go 85.81% <84.00%> (+4.17%) ⬆️
pkg/runner/action.go 84.21% <84.21%> (ø)
pkg/runner/run_context.go 80.03% <96.15%> (+0.38%) ⬆️
... and 9 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@ChristopherHX ChristopherHX marked this pull request as ready for review March 14, 2022 19:17
@ChristopherHX ChristopherHX requested a review from a team as a code owner March 14, 2022 19:17
Copy link
Member

@KnisterPeter KnisterPeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@mergify mergify bot merged commit 4d71071 into nektos:master Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants