Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove composite restrictions #1128

Merged
merged 3 commits into from
May 23, 2022
Merged

Conversation

catthehacker
Copy link
Member

@catthehacker catthehacker commented Apr 15, 2022

As noted by @ChristopherHX on Gitter, composite actions don't need to be restricted anymore
actions/runner#1763

@github-actions
Copy link
Contributor

github-actions bot commented Apr 15, 2022

MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ CREDENTIALS secretlint yes no 0.99s
✅ EDITORCONFIG editorconfig-checker 3 0 0.02s
✅ GIT git_diff yes no 0.01s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

@codecov
Copy link

codecov bot commented Apr 15, 2022

Codecov Report

Merging #1128 (af59418) into master (4f8da0a) will increase coverage by 2.75%.
The diff coverage is 78.62%.

@@            Coverage Diff             @@
##           master    #1128      +/-   ##
==========================================
+ Coverage   57.50%   60.26%   +2.75%     
==========================================
  Files          32       39       +7     
  Lines        4594     4975     +381     
==========================================
+ Hits         2642     2998     +356     
  Misses       1729     1729              
- Partials      223      248      +25     
Impacted Files Coverage Δ
pkg/model/action.go 0.00% <ø> (ø)
pkg/model/github_context.go 79.51% <ø> (ø)
pkg/model/planner.go 50.73% <ø> (+0.32%) ⬆️
pkg/model/workflow.go 54.29% <0.00%> (+3.38%) ⬆️
pkg/container/docker_run.go 5.01% <1.96%> (-0.53%) ⬇️
pkg/common/git.go 49.31% <28.57%> (-0.52%) ⬇️
pkg/container/file_collector.go 44.85% <44.85%> (ø)
pkg/runner/runner.go 73.72% <73.68%> (-2.75%) ⬇️
pkg/exprparser/interpreter.go 75.29% <75.00%> (+1.89%) ⬆️
pkg/runner/logger.go 69.56% <75.47%> (+4.13%) ⬆️
... and 20 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@catthehacker catthehacker marked this pull request as ready for review April 15, 2022 02:57
@catthehacker catthehacker requested a review from a team as a code owner April 15, 2022 02:57
@mergify mergify bot requested a review from a team April 15, 2022 19:35
@mergify

This comment was marked as outdated.

@mergify mergify bot added the conflict PR has conflicts label May 11, 2022
@catthehacker catthehacker force-pushed the fix/remove-composite-restrictions branch from 7562aa0 to b9a2114 Compare May 21, 2022 00:28
@mergify mergify bot removed the conflict PR has conflicts label May 21, 2022
@mergify
Copy link
Contributor

mergify bot commented May 23, 2022

@catthehacker this pull request has failed checks 🛠

@mergify mergify bot added needs-work Extra attention is needed and removed needs-work Extra attention is needed labels May 23, 2022
@mergify mergify bot merged commit ebb408f into master May 23, 2022
@mergify mergify bot deleted the fix/remove-composite-restrictions branch May 23, 2022 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants