Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only perform chown operation for non root users #1250

Merged
merged 1 commit into from
Jul 8, 2022

Conversation

johnfoconnor
Copy link
Contributor

as discussed in #1202 (comment)

@johnfoconnor johnfoconnor requested a review from a team as a code owner July 8, 2022 20:57
@codecov
Copy link

codecov bot commented Jul 8, 2022

Codecov Report

Merging #1250 (1ea49e0) into master (4f8da0a) will increase coverage by 3.97%.
The diff coverage is 74.16%.

@@            Coverage Diff             @@
##           master    #1250      +/-   ##
==========================================
+ Coverage   57.50%   61.48%   +3.97%     
==========================================
  Files          32       40       +8     
  Lines        4594     5492     +898     
==========================================
+ Hits         2642     3377     +735     
- Misses       1729     1845     +116     
- Partials      223      270      +47     
Impacted Files Coverage Δ
pkg/model/action.go 0.00% <0.00%> (ø)
pkg/model/step_result.go 0.00% <ø> (ø)
pkg/container/docker_run.go 14.03% <16.07%> (+8.49%) ⬆️
pkg/container/docker_pull.go 33.33% <33.33%> (ø)
pkg/container/file_collector.go 45.87% <45.87%> (ø)
pkg/common/git/git.go 50.00% <47.91%> (ø)
pkg/container/docker_auth.go 47.61% <50.00%> (+2.61%) ⬆️
pkg/model/workflow.go 54.32% <50.00%> (+3.40%) ⬆️
pkg/exprparser/interpreter.go 73.37% <53.48%> (-0.02%) ⬇️
pkg/model/planner.go 50.73% <60.00%> (+0.32%) ⬆️
... and 30 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@mergify mergify bot merged commit a5ceb54 into nektos:master Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants