Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the number in the github event is of type number #1252

Merged
merged 3 commits into from
Jul 12, 2022

Conversation

KnisterPeter
Copy link
Member

@KnisterPeter KnisterPeter commented Jul 12, 2022

The go %s formattig option outputs the type if the given input value is not of type string.

fmt.Printf("Number: %s\n", 123) // -> Number: %!s(int=123)
fmt.Printf("Number: %d\n", 123) // -> Number: 123
fmt.Printf("Number: %.0f\n", 123.) // -> Number: 123

Update: The parsed type is float64, therefore we should use float formatting

The go %s formattig option outputs the type if the given
input value is not of type string.
@KnisterPeter KnisterPeter requested a review from a team as a code owner July 12, 2022 07:58
@KnisterPeter KnisterPeter self-assigned this Jul 12, 2022
@KnisterPeter KnisterPeter added the kind/bug Something isn't working label Jul 12, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 12, 2022

MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ CREDENTIALS secretlint yes no 1.04s
✅ EDITORCONFIG editorconfig-checker 2 0 0.01s
✅ GIT git_diff yes no 0.01s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

@mergify
Copy link
Contributor

mergify bot commented Jul 12, 2022

@KnisterPeter this pull request has failed checks 🛠

@mergify mergify bot added the needs-work Extra attention is needed label Jul 12, 2022
@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #1252 (1e225dd) into master (4f8da0a) will increase coverage by 3.97%.
The diff coverage is 74.17%.

@@            Coverage Diff             @@
##           master    #1252      +/-   ##
==========================================
+ Coverage   57.50%   61.48%   +3.97%     
==========================================
  Files          32       40       +8     
  Lines        4594     5492     +898     
==========================================
+ Hits         2642     3377     +735     
- Misses       1729     1845     +116     
- Partials      223      270      +47     
Impacted Files Coverage Δ
pkg/model/action.go 0.00% <0.00%> (ø)
pkg/model/step_result.go 0.00% <ø> (ø)
pkg/container/docker_run.go 14.03% <16.07%> (+8.49%) ⬆️
pkg/container/docker_pull.go 33.33% <33.33%> (ø)
pkg/container/file_collector.go 45.87% <45.87%> (ø)
pkg/common/git/git.go 50.00% <47.91%> (ø)
pkg/container/docker_auth.go 47.61% <50.00%> (+2.61%) ⬆️
pkg/model/workflow.go 54.32% <50.00%> (+3.40%) ⬆️
pkg/exprparser/interpreter.go 73.37% <53.48%> (-0.02%) ⬇️
pkg/model/planner.go 50.73% <60.00%> (+0.32%) ⬆️
... and 30 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@mergify mergify bot removed the needs-work Extra attention is needed label Jul 12, 2022
ZauberNerd
ZauberNerd previously approved these changes Jul 12, 2022
@mergify mergify bot merged commit 4094462 into master Jul 12, 2022
@mergify mergify bot deleted the pr-number-is-a-number branch July 12, 2022 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants