-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Host environment #1293
feat: Host environment #1293
Conversation
🦙 MegaLinter status: ✅ SUCCESS
See errors details in artifact MegaLinter reports on CI Job page |
Codecov Report
@@ Coverage Diff @@
## master #1293 +/- ##
==========================================
+ Coverage 57.50% 60.37% +2.86%
==========================================
Files 32 44 +12
Lines 4594 6950 +2356
==========================================
+ Hits 2642 4196 +1554
- Misses 1729 2451 +722
- Partials 223 303 +80
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I will look into this starting next week. |
} | ||
} | ||
|
||
func (e *HostEnvironment) UpdateFromEnv(srcPath string, env *map[string]string) common.Executor { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Until Today this was a copy from docker_run.go.
The copied code has big flaws with parsing the env file, so this code is rewritten from scatch to pass all existing tests.
Update:
See the original code https://github.com/actions/runner/blob/3fc993da5946feac15c8020c414bca450f018f3e/src/Runner.Worker/FileCommandManager.cs#L285-L367, which differs significantly from the current docker_run impl.
@ChristopherHX this pull request is now in conflict 😩 Will be resolved once cplee finishs his first review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ChristopherHX - sorry for the delays with this one. Finally got a chance to try out locally. Looks great, thanks for your patience!!
@cplee I need your approval later a second time for this PR, because this PR is not the first in the merge queue we will see a small merge conflict today. |
@ChristopherHX - I'll be watching 👀 |
@ChristopherHX this pull request has failed checks 🛠 |
@ChristopherHX this pull request has failed checks 🛠 |
2 similar comments
@ChristopherHX this pull request has failed checks 🛠 |
@ChristopherHX this pull request has failed checks 🛠 |
🎉🎉🎉 |
Thank you, it was a long way |
Thanks for your hard work @ChristopherHX |
This is my refactored implementation of a non docker based executor
To test running actions without docker specify
-P ubuntu-latest=-self-hosted
I refactored a larger amount of code
/var/run/act
PATH
manipulation to use custom list seperator, while not running in dockerFixes #97
I need to look into possible linting violations
Known Issues
I want to know if this design change has a chance to get merged
Some implementation Details
PATH
env var to use the stdlib directlyCommit Message
{{title}} (#1293)