Mapping workflow_dispatch inputs into the Expression inputs context

[KnisterPeter]

This changes adds the workflow_dispatch event inputs to the inputs context and maintaining the boolean type.

[github-actions]

🦙 MegaLinter status: ✅ SUCCESS

Descriptor	Linter	Files	Fixed	Errors	Elapsed time
✅ EDITORCONFIG	editorconfig-checker	3		0	0.02s
✅ REPOSITORY	gitleaks	yes		no	2.48s
✅ REPOSITORY	git_diff	yes		no	0.0s
✅ REPOSITORY	secretlint	yes		no	1.01s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by

[codecov]

Codecov Report

Merging #1363 (c767290) into master (4f8da0a) will increase coverage by 6.39%.
The diff coverage is 74.70%.

@@            Coverage Diff             @@
##           master    #1363      +/-   ##
==========================================
+ Coverage   57.50%   63.90%   +6.39%     
==========================================
  Files          32       41       +9     
  Lines        4594     6452    +1858     
==========================================
+ Hits         2642     4123    +1481     
- Misses       1729     2034     +305     
- Partials      223      295      +72     

Impacted Files	Coverage Δ
pkg/model/action.go	0.00% <0.00%> (ø)
pkg/model/step_result.go	0.00% <ø> (ø)
pkg/container/docker_run.go	12.82% <11.63%> (+7.27%)	⬆️
pkg/model/workflow.go	47.14% <22.22%> (-3.77%)	⬇️
pkg/model/planner.go	48.82% <25.00%> (-1.60%)	⬇️
pkg/container/docker_pull.go	33.33% <33.33%> (ø)
pkg/container/file_collector.go	45.87% <45.87%> (ø)
pkg/common/git/git.go	50.00% <47.91%> (ø)
pkg/container/docker_auth.go	47.61% <50.00%> (+2.61%)	⬆️
pkg/exprparser/interpreter.go	73.37% <53.48%> (-0.02%)	⬇️
... and 31 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[ChristopherHX]

I'm not shure, but I believe that this change conflics #1345. This raises the question, which should be merged first?

Other than that I want to tell you that github stores all workflow_dispatch input values as strings inside github.event.inputs.* and only respects the boolean type in the inputs.* context.
E.g. github would provide this payload

{
  "inputs": {
    "required": "required input",
    "boolean": "true"
  }
}

[KnisterPeter]

Yes they might conflict. If either one is merged, I'll rework the other. 😊

[ChristopherHX]

Thank you for adding the missing code to assign the inputs context. You get my +1, even if the test doesn't exactly match githubs behavior.

[KnisterPeter]

You are right regarding the input types. We need to coerce them.

[KnisterPeter]

This should reflect githubs behavior now as well

[ChristopherHX]

Looks good to me

[mergify]

@KnisterPeter this pull request is now in conflict 😩

[mergify]

@KnisterPeter this pull request has failed checks 🛠

[mergify]

@KnisterPeter this pull request has failed checks 🛠

[ChristopherHX]

The PR checks are failing due to actions/hello-world-docker-action@778decc, rerun doesn't help.

[mergify]

@KnisterPeter this pull request has failed checks 🛠

[KnisterPeter]

Oh I see. We are depending on code which is not managed by the act team and that did change.
Not a good state I would say.

[KnisterPeter]

I did re-run while the CI indicates that two tests failed (https://github.com/nektos/act/actions/runs/3263285979/jobs/5362282276#step:6:33010) and both are fine locally. But anyway if the error lies in the external code I guess I will wait with this PR until its fixed.

[ChristopherHX]

... both are fine locally

You would need to flush your docker image cache (some stale images with act in it's name) to observe this locally, act currently never rebuilds docker actions. The CI always needs to build all docker actions.

[itsjoekent]

Any chance this can get released soon? Looks like the last release was 19 days ago

[KnisterPeter]

There is one usual release per month