Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add remote reusable workflows #1525

Merged
merged 3 commits into from
Jan 19, 2023
Merged

Conversation

KnisterPeter
Copy link
Member

@KnisterPeter KnisterPeter commented Dec 20, 2022

This changes adds cloning of a remote repository to
run a workflow included in it.

Closes #826

This changes adds cloning of a remote repository to
run a workflow included in it.

Closes #826
@KnisterPeter KnisterPeter self-assigned this Dec 20, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 20, 2022

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 2 0 0.01s
✅ REPOSITORY gitleaks yes no 2.42s
✅ REPOSITORY git_diff yes no 0.0s
✅ REPOSITORY secretlint yes no 0.94s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

We need wait for the full clone (and only clone once)
before we start to plan the execution for a remote workflow
@pull-request-size pull-request-size bot added size/L and removed size/M labels Dec 20, 2022
@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Merging #1525 (94bd983) into master (4989f44) will increase coverage by 0.71%.
The diff coverage is 77.40%.

@@            Coverage Diff             @@
##           master    #1525      +/-   ##
==========================================
+ Coverage   61.22%   61.93%   +0.71%     
==========================================
  Files          46       46              
  Lines        7141     7185      +44     
==========================================
+ Hits         4372     4450      +78     
+ Misses       2462     2428      -34     
  Partials      307      307              
Impacted Files Coverage Δ
pkg/container/docker_cli.go 82.23% <ø> (ø)
pkg/container/docker_logger.go 52.08% <ø> (ø)
pkg/container/docker_pull.go 33.33% <ø> (ø)
pkg/container/docker_run.go 13.58% <ø> (ø)
pkg/container/docker_volume.go 0.00% <ø> (ø)
pkg/runner/run_context.go 78.81% <0.00%> (ø)
pkg/container/docker_images.go 27.02% <29.41%> (-4.13%) ⬇️
pkg/container/docker_auth.go 51.35% <56.25%> (+3.73%) ⬆️
pkg/runner/runner.go 86.45% <66.66%> (-2.05%) ⬇️
pkg/common/git/git.go 57.72% <79.71%> (+7.72%) ⬆️
... and 11 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@KnisterPeter KnisterPeter marked this pull request as ready for review December 20, 2022 14:46
@KnisterPeter KnisterPeter requested a review from a team as a code owner December 20, 2022 14:46
Copy link
Contributor

@ChristopherHX ChristopherHX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@mergify
Copy link
Contributor

mergify bot commented Jan 19, 2023

@KnisterPeter this pull request has failed checks 🛠

@mergify mergify bot added needs-work Extra attention is needed and removed needs-work Extra attention is needed labels Jan 19, 2023
@mergify mergify bot merged commit 82a8c1e into master Jan 19, 2023
@mergify mergify bot deleted the remote-reusable-workflows branch January 19, 2023 20:49
@gblikas
Copy link

gblikas commented Oct 4, 2024

@KnisterPeter is there a corresponding PR or release that supports the local Github workflow references, as in: https://github.blog/changelog/2022-01-25-github-actions-reusable-workflows-can-be-referenced-locally/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue: support for reusable workflows
4 participants