-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: compare properties of Invalid types #1645
Conversation
@alex-savchuk this pull request has failed checks 🛠 |
Problem was in processing of "github.event.pull_request.head.repo.full_name != github.event.pull_request.base.repo.full_name" Fixed:
|
Codecov Report
@@ Coverage Diff @@
## master #1645 +/- ##
==========================================
+ Coverage 61.22% 62.43% +1.20%
==========================================
Files 46 48 +2
Lines 7141 7440 +299
==========================================
+ Hits 4372 4645 +273
- Misses 2462 2476 +14
- Partials 307 319 +12
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments.
I'm not blocking other maintainers to approve this for merging
fix: compare properties of Invalid types nektos#1643
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️
fix: compare properties of Invalid types #1643