Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve XDG Spec supporting #1656

Merged
merged 2 commits into from
Mar 3, 2023
Merged

Improve XDG Spec supporting #1656

merged 2 commits into from
Mar 3, 2023

Conversation

tony-sol
Copy link
Contributor

@tony-sol tony-sol commented Mar 1, 2023

Switch from direct using of XDG_CONFIG_HOME env variable to adrg/xdg lib.

Now, it will be support xdg across windows/darwin/unix platforms and looks for config file like:

~/.actrc
"${XDG_CONFIG_HOME}/act/actrc"
"${XDG_CONFIG_HOME}/.actrc"
./.actrc

@tony-sol tony-sol requested a review from a team as a code owner March 1, 2023 21:06
@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Merging #1656 (fc95fad) into master (4989f44) will increase coverage by 1.26%.
The diff coverage is 71.47%.

@@            Coverage Diff             @@
##           master    #1656      +/-   ##
==========================================
+ Coverage   61.22%   62.49%   +1.26%     
==========================================
  Files          46       48       +2     
  Lines        7141     7452     +311     
==========================================
+ Hits         4372     4657     +285     
- Misses       2462     2476      +14     
- Partials      307      319      +12     
Impacted Files Coverage Δ
pkg/container/docker_cli.go 82.23% <ø> (ø)
pkg/container/docker_logger.go 52.08% <ø> (ø)
pkg/container/docker_pull.go 33.33% <ø> (ø)
pkg/container/docker_run.go 14.08% <ø> (+0.49%) ⬆️
pkg/container/docker_volume.go 0.00% <ø> (ø)
pkg/container/file_collector.go 37.30% <0.00%> (ø)
pkg/container/host_environment.go 0.00% <0.00%> (ø)
pkg/model/workflow.go 42.11% <ø> (ø)
pkg/model/planner.go 44.71% <21.27%> (-4.12%) ⬇️
pkg/container/docker_images.go 27.02% <29.41%> (-4.13%) ⬇️
... and 29 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mergify mergify bot merged commit 6601d8d into nektos:master Mar 3, 2023
@s3igo s3igo mentioned this pull request Mar 23, 2023
2 tasks
@mrnossiom
Copy link
Contributor

It seems that even though act looks for config files in these dirs, it still writes the default config to ~/.actrc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants