Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct ref and ref_name #1672

Merged
merged 2 commits into from
Mar 9, 2023
Merged

fix: correct ref and ref_name #1672

merged 2 commits into from
Mar 9, 2023

Conversation

KnisterPeter
Copy link
Member

The ref in the GitHub context is always full qualified (e.g. refs/heads/branch, refs/tags/v1).
The ref_name is the ref with the stripped prefix.

In case of pull_requests, this is the merge commit ref (e.g. refs/pull/123/merge -> 123/merge).

The ref in the GitHub context is always full qualified
(e.g. refs/heads/branch, refs/tags/v1).
The ref_name is the ref with the strippep prefix.
In case of pull_requests, this is the merge commit ref
(e.g. refs/pull/123/merge -> 123/merge).
@KnisterPeter KnisterPeter added the kind/bug Something isn't working label Mar 9, 2023
@KnisterPeter KnisterPeter self-assigned this Mar 9, 2023
@KnisterPeter KnisterPeter requested a review from a team as a code owner March 9, 2023 13:41
@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 3 0 0.02s
✅ REPOSITORY gitleaks yes no 2.43s
✅ REPOSITORY git_diff yes no 0.0s
✅ REPOSITORY secretlint yes no 1.34s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@mergify
Copy link
Contributor

mergify bot commented Mar 9, 2023

@KnisterPeter this pull request has failed checks 🛠

@mergify mergify bot added the needs-work Extra attention is needed label Mar 9, 2023
@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Merging #1672 (c62298f) into master (4989f44) will increase coverage by 1.48%.
The diff coverage is 73.66%.

@@            Coverage Diff             @@
##           master    #1672      +/-   ##
==========================================
+ Coverage   61.22%   62.71%   +1.48%     
==========================================
  Files          46       48       +2     
  Lines        7141     7458     +317     
==========================================
+ Hits         4372     4677     +305     
+ Misses       2462     2461       -1     
- Partials      307      320      +13     
Impacted Files Coverage Δ
pkg/container/docker_cli.go 82.23% <ø> (ø)
pkg/container/docker_logger.go 52.08% <ø> (ø)
pkg/container/docker_pull.go 33.33% <ø> (ø)
pkg/container/docker_run.go 14.08% <0.00%> (+0.49%) ⬆️
pkg/container/docker_volume.go 0.00% <ø> (ø)
pkg/container/file_collector.go 37.30% <0.00%> (ø)
pkg/container/host_environment.go 0.00% <0.00%> (ø)
pkg/exprparser/functions.go 66.32% <0.00%> (-1.04%) ⬇️
pkg/model/workflow.go 42.11% <ø> (ø)
pkg/model/planner.go 44.71% <21.27%> (-4.12%) ⬇️
... and 30 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mergify mergify bot removed the needs-work Extra attention is needed label Mar 9, 2023
@mergify mergify bot merged commit 6744e68 into master Mar 9, 2023
@mergify mergify bot deleted the fix-tag-name branch March 9, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants