Support for docker steps in host environment

[shubham149]

Network mode in host environment is set to container network earlier. But the container network is not present. This PR uses default as network mode in case host environment is enabled.

Also, setting working directory for container step to same as one specified in the input params.

[ChristopherHX]

Also, setting working directory for container step to same as one specified in the input params.

I'm concerned about this change, ToContainerPath is used to move fileio from readonly checkout into a scratch space under .cache. This breaks file operations of host environment if the exact workdir should be translated

Seems like my tests also show this is a bad idea to remove.

• you need a bind mount for workdir of host environment
• you need a bind mount for env files (for outputs)

I'm 100% fine with the rest of your changes.

[mergify]

@shubham149 this pull request has failed checks 🛠

[shubham149]

@ChristopherHX I have reverted workdir changes from this pull request.

Is there a way we can set the working directory for container steps same as input working directory for host env?

[codecov]

Codecov Report

Merging #1674 (8be7541) into master (4989f44) will increase coverage by 1.51%.
The diff coverage is 73.57%.

@@            Coverage Diff             @@
##           master    #1674      +/-   ##
==========================================
+ Coverage   61.22%   62.73%   +1.51%     
==========================================
  Files          46       48       +2     
  Lines        7141     7463     +322     
==========================================
+ Hits         4372     4682     +310     
+ Misses       2462     2461       -1     
- Partials      307      320      +13     

Impacted Files	Coverage Δ
pkg/container/docker_cli.go	82.23% <ø> (ø)
pkg/container/docker_logger.go	52.08% <ø> (ø)
pkg/container/docker_pull.go	33.33% <ø> (ø)
pkg/container/docker_run.go	14.08% <0.00%> (+0.49%)	⬆️
pkg/container/docker_volume.go	0.00% <ø> (ø)
pkg/container/file_collector.go	37.30% <0.00%> (ø)
pkg/container/host_environment.go	0.00% <0.00%> (ø)
pkg/exprparser/functions.go	66.32% <0.00%> (-1.04%)	⬇️
pkg/model/workflow.go	42.11% <ø> (ø)
pkg/model/planner.go	44.71% <21.27%> (-4.12%)	⬇️
... and 20 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[ChristopherHX]

You have started to work on a very complex area of act

The current design of HostEnvironment is not really compatible with docker actions..., multiple container path translations are not implemented and volume mounts of workdir won't work with stepcontainer without jobcontainer.

You can use tocontainerpath of

act/pkg/container/linux_container_environment_extensions.go

Line 19 in 6744e68

func (*LinuxContainerEnvironmentExtensions) ToContainerPath(path string) string {

Like used in the startjobcontainer implementation.

To translate the workdir for the docker action start, there are probably more places causing issues.

After the step container is created, you may need to replace some calls of jobcontainer.tocontainerpath with stepcontainer.tocontainerpath. (eventually you have to replace interface Container with ExecutionContext to get access)

Addidionally you need to translate all host paths of your inputs and env's back to a docker container paths. (Currently in act, either every env uses docker paths or host paths, never both at same time in one job)

[shubham149]

@ChristopherHX Can we merge this PR? I have removed the workDir changes from it. If anything is pending, let me know about it.
I will work on workDir change separately.

[ChristopherHX]

Yes, you need another approval.