Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add server_url attribute to github context #1727

Merged
merged 2 commits into from
Apr 13, 2023
Merged

Conversation

KnisterPeter
Copy link
Member

The server_urL attribute was missing in the github context.
Previously it was exposed as environment variable only.

Closes #1726

The `server_urL` attribute was missing in the `github` context.
Previously it was exposed as environment variable only.

Closes #1726
@KnisterPeter KnisterPeter requested a review from a team as a code owner April 13, 2023 12:38
@KnisterPeter KnisterPeter self-assigned this Apr 13, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 13, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 2 0 0.02s
✅ REPOSITORY gitleaks yes no 2.51s
✅ REPOSITORY git_diff yes no 0.0s
✅ REPOSITORY secretlint yes no 1.2s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

ChristopherHX
ChristopherHX previously approved these changes Apr 13, 2023
pkg/runner/run_context.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Merging #1727 (6e1f5eb) into master (4989f44) will increase coverage by 1.23%.
The diff coverage is 69.44%.

@@            Coverage Diff             @@
##           master    #1727      +/-   ##
==========================================
+ Coverage   61.22%   62.46%   +1.23%     
==========================================
  Files          46       48       +2     
  Lines        7141     7523     +382     
==========================================
+ Hits         4372     4699     +327     
- Misses       2462     2502      +40     
- Partials      307      322      +15     
Impacted Files Coverage Δ
pkg/common/outbound_ip.go 0.00% <0.00%> (ø)
pkg/container/docker_cli.go 82.23% <ø> (ø)
pkg/container/docker_logger.go 52.08% <ø> (ø)
pkg/container/docker_pull.go 33.33% <ø> (ø)
pkg/container/docker_run.go 14.08% <0.00%> (+0.49%) ⬆️
pkg/container/docker_volume.go 0.00% <ø> (ø)
pkg/container/file_collector.go 39.68% <0.00%> (+2.38%) ⬆️
pkg/container/host_environment.go 0.00% <0.00%> (ø)
pkg/exprparser/functions.go 66.32% <0.00%> (-1.04%) ⬇️
pkg/model/workflow.go 42.11% <ø> (ø)
... and 21 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mergify mergify bot merged commit c0130ed into master Apr 13, 2023
@mergify mergify bot deleted the set-github-server-url branch April 13, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The --github-instance parameter does not set the ${{ github.server_url }} argument.
3 participants