Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve watchAndRun #1743

Merged
merged 5 commits into from
Apr 19, 2023
Merged

Conversation

wolfogre
Copy link
Member

Fix #1741

@wolfogre wolfogre requested a review from a team as a code owner April 19, 2023 02:38
@wolfogre wolfogre added the area/cli Relating to the cli label Apr 19, 2023
@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Merging #1743 (16ff60e) into master (4989f44) will increase coverage by 1.11%.
The diff coverage is 66.12%.

@@            Coverage Diff             @@
##           master    #1743      +/-   ##
==========================================
+ Coverage   61.22%   62.34%   +1.11%     
==========================================
  Files          46       48       +2     
  Lines        7141     7579     +438     
==========================================
+ Hits         4372     4725     +353     
- Misses       2462     2525      +63     
- Partials      307      329      +22     
Impacted Files Coverage Δ
pkg/common/outbound_ip.go 0.00% <0.00%> (ø)
pkg/container/docker_cli.go 82.23% <ø> (ø)
pkg/container/docker_logger.go 52.08% <ø> (ø)
pkg/container/docker_pull.go 33.33% <ø> (ø)
pkg/container/docker_run.go 13.99% <0.00%> (+0.40%) ⬆️
pkg/container/docker_volume.go 0.00% <ø> (ø)
pkg/container/file_collector.go 39.68% <0.00%> (+2.38%) ⬆️
pkg/container/host_environment.go 0.00% <0.00%> (ø)
...ontainer/linux_container_environment_extensions.go 23.07% <0.00%> (-1.25%) ⬇️
pkg/exprparser/functions.go 66.32% <0.00%> (-1.04%) ⬇️
... and 22 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mergify mergify bot merged commit 3715266 into nektos:master Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli Relating to the cli size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

potential data races
2 participants