Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using log.Fatal in pkg/* #1759

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Conversation

Zettat123
Copy link
Contributor

Follow up #1705

Replace some log.Fatal with decodeNode in pkg/model/workflow.go.

@Zettat123 Zettat123 requested a review from a team as a code owner April 24, 2023 09:35
@mergify
Copy link
Contributor

mergify bot commented Apr 24, 2023

@Zettat123 this pull request has failed checks 🛠

@mergify mergify bot added the needs-work Extra attention is needed label Apr 24, 2023
@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Merging #1759 (41db532) into master (4989f44) will increase coverage by 1.16%.
The diff coverage is 65.07%.

@@            Coverage Diff             @@
##           master    #1759      +/-   ##
==========================================
+ Coverage   61.22%   62.38%   +1.16%     
==========================================
  Files          46       48       +2     
  Lines        7141     7569     +428     
==========================================
+ Hits         4372     4722     +350     
- Misses       2462     2518      +56     
- Partials      307      329      +22     
Impacted Files Coverage Δ
pkg/common/outbound_ip.go 0.00% <0.00%> (ø)
pkg/container/docker_cli.go 82.23% <ø> (ø)
pkg/container/docker_logger.go 52.08% <ø> (ø)
pkg/container/docker_pull.go 33.33% <ø> (ø)
pkg/container/docker_run.go 13.58% <0.00%> (-0.01%) ⬇️
pkg/container/docker_volume.go 0.00% <ø> (ø)
pkg/container/file_collector.go 39.68% <0.00%> (+2.38%) ⬆️
pkg/container/host_environment.go 0.00% <0.00%> (ø)
...ontainer/linux_container_environment_extensions.go 23.07% <0.00%> (-1.25%) ⬇️
pkg/exprparser/functions.go 66.32% <0.00%> (-1.04%) ⬇️
... and 22 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mergify mergify bot removed the needs-work Extra attention is needed label Apr 25, 2023
@mergify mergify bot merged commit baf3bcf into nektos:master Apr 25, 2023
@Zettat123 Zettat123 deleted the avoid-log-fatal branch April 25, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants