Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fallback to unauthenticated pull #1774

Merged
merged 6 commits into from
May 3, 2023
Merged

Conversation

ChristopherHX
Copy link
Contributor

This change adds more verbose logging regarding reading docker auth store and tries an unauthenticated pull

Fixes #1769
Fixes #1165

@github-actions
Copy link
Contributor

github-actions bot commented Apr 27, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 1 0 0.01s
✅ REPOSITORY gitleaks yes no 2.52s
✅ REPOSITORY git_diff yes no 0.0s
✅ REPOSITORY secretlint yes no 1.18s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Merging #1774 (5ea464c) into master (4989f44) will increase coverage by 1.27%.
The diff coverage is 64.94%.

@@            Coverage Diff             @@
##           master    #1774      +/-   ##
==========================================
+ Coverage   61.22%   62.50%   +1.27%     
==========================================
  Files          46       51       +5     
  Lines        7141     8075     +934     
==========================================
+ Hits         4372     5047     +675     
- Misses       2462     2649     +187     
- Partials      307      379      +72     
Impacted Files Coverage Δ
pkg/common/outbound_ip.go 0.00% <0.00%> (ø)
pkg/container/docker_cli.go 82.23% <ø> (ø)
pkg/container/docker_logger.go 52.08% <ø> (ø)
pkg/container/docker_run.go 13.58% <0.00%> (-0.01%) ⬇️
pkg/container/docker_volume.go 0.00% <ø> (ø)
pkg/container/file_collector.go 39.68% <0.00%> (+2.38%) ⬆️
pkg/container/host_environment.go 0.00% <0.00%> (ø)
...ontainer/linux_container_environment_extensions.go 23.07% <0.00%> (-1.25%) ⬇️
pkg/exprparser/functions.go 66.32% <0.00%> (-1.04%) ⬇️
pkg/model/workflow.go 42.44% <9.09%> (+0.32%) ⬆️
... and 25 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ChristopherHX ChristopherHX marked this pull request as ready for review April 28, 2023 21:07
@ChristopherHX ChristopherHX requested a review from a team as a code owner April 28, 2023 21:07
@ChristopherHX
Copy link
Contributor Author

Marked as ready for review via feedback in #1165 (reply in thread)

@mergify mergify bot merged commit aa21277 into master May 3, 2023
@mergify mergify bot deleted the fallback-unauthenticated branch May 3, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants