Fix bug in processing jobs on platforms without Docker #1834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@psa this pull request has failed checks 🛠 |
added 3 commits
June 3, 2023 11:01
Log the full contents of the job protobuf to make debugging jobs easier
The caller may mis-calculate the number of CPUs as zero, in which case ensure that at least one thread is spawned.
For hosts without docker, GetHostInfo() returns a blank struct which has zero CPUs and causes downstream trouble.
Codecov Report
@@ Coverage Diff @@
## master #1834 +/- ##
==========================================
+ Coverage 61.22% 62.62% +1.39%
==========================================
Files 46 51 +5
Lines 7141 8187 +1046
==========================================
+ Hits 4372 5127 +755
- Misses 2462 2673 +211
- Partials 307 387 +80
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cplee
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The container.GetHostInfo() struct is returned empty on hosts without docker and this results in passing zero parallelism to the parallel executor.
Use Golang's inbuilt runtime.NumCPU() instead. This should be safe on Docker too.
I've also added a fair bit of debug logging to assist with debugging the struct passed to the runner. This is leftover from my original line of inquiry, but it seemed like useful code so I kept it in the change.