Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cmd/root): simplify parseEnvs #2162

Merged
merged 2 commits into from
Jan 24, 2024
Merged

refactor(cmd/root): simplify parseEnvs #2162

merged 2 commits into from
Jan 24, 2024

Commits on Jan 21, 2024

  1. refactor(cmd/root): simplify parseEnvs

    Prior to this commit, `parseEnvs` accept two parameters:
    
      1. env []string
      2. envs map[string]string
    
    `parseEnvs` then do a `nil` check for `env`. However, we never pass a
    `nil` `env` to `parseEnvs` in `newRunCommand`.
    
    This commit simplify the `parseEnvs` function to accept just one
    `env []string` parameter and return the result as `map[string]string`
    instead.
    
    Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
    Juneezee committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    6c137c7 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. Configuration menu
    Copy the full SHA
    75260b8 View commit details
    Browse the repository at this point in the history