-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Actions Artifacts v4 backend #2224
Conversation
🦙 MegaLinter status:
|
Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
---|---|---|---|---|---|
✅ EDITORCONFIG | editorconfig-checker | 11 | 0 | 0.05s | |
✅ REPOSITORY | gitleaks | yes | no | 2.34s | |
✅ REPOSITORY | git_diff | yes | no | 0.01s | |
✅ REPOSITORY | grype | yes | no | 7.45s | |
✅ REPOSITORY | secretlint | yes | no | 1.08s | |
✅ REPOSITORY | trivy-sbom | yes | no | 0.63s | |
✅ REPOSITORY | trufflehog | yes | no | 4.51s | |
prettier | 1 | 1 | 0.28s | ||
✅ YAML | v8r | 1 | 0 | 1.48s |
See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true
in mega-linter.yml to validate all sources, not only the diff
@TWiStErRob @zdenardi it's now your turn to test this if this satisfies your needs. The following works (* on:
push:
jobs:
_5:
runs-on: ubuntu-latest
steps:
- run: env
- run: |
github:
${{ tojson(github) }}
inputs:
${{ tojson(inputs) }}
matrix:
${{ tojson(matrix) }}
needs:
${{ tojson(needs) }}
strategy:
${{ tojson(strategy) }}
shell: cp {0} context.txt
- uses: christopherhx/gitea-upload-artifact@v4
with:
name: test
path: context.txt
- uses: christopherhx/gitea-download-artifact@v4
with:
name: test
path: out
- run: cat out/context.txt For anything else someone need to take this over. I'm more satisfied by full client + server reimplementations of actions with authentication, instead of a pseudo server like for act cli. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2224 +/- ##
===========================================
+ Coverage 61.56% 76.35% +14.78%
===========================================
Files 53 61 +8
Lines 9002 7777 -1225
===========================================
+ Hits 5542 5938 +396
+ Misses 3020 1286 -1734
- Partials 440 553 +113 ☔ View full report in Codecov by Sentry. |
Awesome! I can confirm this works (I grabbed the executable artifact from https://github.com/nektos/act/actions/runs/7959602137).
|
A pretty insecure backport with stubs and removed checks
I'm the original author of most code in artifacts_v4.go and the dumped proto code
jwt code is from the gitea project
Use at your own risk
If you want tests, someone else need to take this over.
Tests for the full Gitea Implementation can be found here: go-gitea/gitea#28965
Fixes #2135
dumped proto file has been deleted, because I'm not going to make changes to that file to satisfy the linter