fix: prevent unintended input replacement in reusable workflows with workflow_dispatch when using workflow_call

[mahmud2011]

Closes: #2464

[ChristopherHX]

FYI: This reverts a feature that has been accepted by the owner in #1845 that has 9 upvotes in the original issue. fixed

[mahmud2011]

@ChristopherHX I reverted it.

[ChristopherHX]

Yes I confirm that you no longer remove the feature I mentioned.

Could you please add a pkg/runner/testdata/<testname>/workflow_dispatch.yml and a reusable workflow in pkg/runner/testdata/.github/workflows/<testworkflow>.yml that assert that your change works now and in a year?

Then a new line like

act/pkg/runner/runner_test.go

Line 306 in 9135745

{workdir, "workflow_dispatch", "workflow_dispatch", "", platforms, secrets},

where the first workflow_dispatch should be replaced by <testname>

in the workflow_dispatch.yml do a

uses: ./.github/workflows/<testworkflow>.yml

see uses https://github.com/nektos/act/tree/master/pkg/runner/testdata/uses-workflow for an example.

didn't test yet as you always need two approvals, I take me some time for actually testing this

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.75%. Comparing base (5a80a04) to head (4fabbc7).
Report is 140 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2502      +/-   ##
==========================================
+ Coverage   61.56%   68.75%   +7.19%     
==========================================
  Files          53       71      +18     
  Lines        9002    10918    +1916     
==========================================
+ Hits         5542     7507    +1965     
+ Misses       3020     2848     -172     
- Partials      440      563     +123     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ChristopherHX]

Added you sample workflow as test with an assert step all good now

[mahmud2011]

Thanks. I was about to write the tests.

[ChristopherHX]

I was about to write the tests.

More tests are welcome, I reapprove if needed as the most active member.

However we need to wait for one other member to make a merge happen.

[ChristopherSchmidt89]

Hi, it would be highly appreciated if this fix gets another review to resolve the mentioned issue!
Thanks

[blackhatcrazy]

likewise, this would help our dev setup significantly! Please bring this in soon.

[mergify]

@mahmud2011 this pull request has failed checks 🛠