Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for dereferenced map properties #2635

Merged
merged 5 commits into from
Jan 31, 2025
Merged

Conversation

m1r4c
Copy link
Contributor

@m1r4c m1r4c commented Jan 28, 2025

Fixes #2591

@m1r4c m1r4c requested a review from a team as a code owner January 28, 2025 17:40
ChristopherHX
ChristopherHX previously approved these changes Jan 30, 2025
Copy link
Contributor

@ChristopherHX ChristopherHX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for implementing this 👍

I may cherry pick this into my new upstream, on actions-oss to release this earlier

pkg/exprparser/functions_test.go Outdated Show resolved Hide resolved
pkg/exprparser/functions_test.go Show resolved Hide resolved
Co-authored-by: ChristopherHX <christopher.homberger@web.de>
Co-authored-by: ChristopherHX <christopher.homberger@web.de>
@m1r4c
Copy link
Contributor Author

m1r4c commented Jan 30, 2025

Thank you for implementing this 👍

I may cherry pick this into my new upstream, on actions-oss to release this earlier

@ChristopherHX thank you for this awesome tool! I've applied your suggestions so feel free to merge at any time :)

ChristopherHX
ChristopherHX previously approved these changes Jan 30, 2025
Copy link
Contributor

mergify bot commented Jan 30, 2025

@m1r4c this pull request has failed checks 🛠

@mergify mergify bot added the needs-work Extra attention is needed label Jan 30, 2025
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 70.83333% with 7 lines in your changes missing coverage. Please review.

Project coverage is 68.72%. Comparing base (5a80a04) to head (518c7f3).
Report is 155 commits behind head on master.

Files with missing lines Patch % Lines
pkg/exprparser/interpreter.go 70.83% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2635      +/-   ##
==========================================
+ Coverage   61.56%   68.72%   +7.16%     
==========================================
  Files          53       71      +18     
  Lines        9002    10942    +1940     
==========================================
+ Hits         5542     7520    +1978     
+ Misses       3020     2857     -163     
- Partials      440      565     +125     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mergify mergify bot removed the needs-work Extra attention is needed label Jan 30, 2025
@mergify mergify bot merged commit 9dd0854 into nektos:master Jan 31, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Difference between github and act when running contains(needs.*.result, 'success')
3 participants