fix: hide masked value #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ::add-mask:: command output logs the value to be masked. This does expose critical information which should be hidden from the output.
Codecov Report
@@ Coverage Diff @@
## master #668 +/- ##
==========================================
+ Coverage 49.27% 50.61% +1.34%
==========================================
Files 23 23
Lines 2401 2525 +124
==========================================
+ Hits 1183 1278 +95
- Misses 1090 1111 +21
- Partials 128 136 +8
Continue to review full report at Codecov.
|
|
@cplee Do you have any thoughts on this? |
|
Could you add tests, please? |
|
@catthehacker I've updated it and added a test for this |
|
@catthehacker Can you review please? |
catthehacker
approved these changes
May 15, 2021
cplee
approved these changes
May 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
::add-mask::command output logs the value to be masked.The current implementation does expose critical information which should be hidden from the output.
Note: This PR does not implement proper mask handling. It just suppresses the output of the secret in the
add-maskcommand.