Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: GITHUB_PATH should prepend #690

Merged
merged 2 commits into from
May 18, 2021
Merged

Fix: GITHUB_PATH should prepend #690

merged 2 commits into from
May 18, 2021

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented May 18, 2021

closes #689

@jsoref jsoref requested a review from a team as a code owner May 18, 2021 07:07
@jsoref jsoref changed the title Issue 689 Fix: GITHUB_PATH should prepend May 18, 2021
@codecov
Copy link

codecov bot commented May 18, 2021

Codecov Report

Merging #690 (ea6ac6d) into master (0f04942) will increase coverage by 1.16%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #690      +/-   ##
==========================================
+ Coverage   49.27%   50.43%   +1.16%     
==========================================
  Files          23       23              
  Lines        2401     2534     +133     
==========================================
+ Hits         1183     1278      +95     
- Misses       1090     1116      +26     
- Partials      128      140      +12     
Impacted Files Coverage Δ
pkg/container/docker_run.go 1.82% <0.00%> (-0.11%) ⬇️
pkg/common/git.go 54.10% <31.03%> (-5.69%) ⬇️
pkg/model/workflow.go 30.71% <33.33%> (+5.00%) ⬆️
pkg/model/planner.go 34.56% <41.37%> (+1.48%) ⬆️
pkg/container/docker_pull.go 36.17% <64.70%> (+17.98%) ⬆️
pkg/runner/step_context.go 71.99% <71.53%> (+3.04%) ⬆️
pkg/runner/run_context.go 79.74% <94.82%> (+3.33%) ⬆️
pkg/runner/command.go 90.58% <100.00%> (+2.35%) ⬆️
pkg/runner/runner.go 76.92% <100.00%> (+0.45%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38f6dfb...ea6ac6d. Read the comment docs.

@mergify mergify bot requested a review from a team May 18, 2021 07:23
@mergify mergify bot merged commit 29ea8cf into nektos:master May 18, 2021
@jsoref jsoref deleted the issue-689 branch May 18, 2021 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue: GITHUB_PATH should prepend
3 participants