Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use github auth token for pulling a repository #693

Merged
merged 1 commit into from
May 19, 2021

Conversation

ZauberNerd
Copy link
Contributor

Seems like we missed another one 🙈 . This happens when using actions with a branch spec instead of a tag (i.e. uses: actions/checkout@master instead of actions/checkout@v2).
#687

Co-Authored-By: Markus Wolf <markus.wolf@new-work.se>
@ZauberNerd ZauberNerd requested a review from a team as a code owner May 19, 2021 13:30
@codecov
Copy link

codecov bot commented May 19, 2021

Codecov Report

Merging #693 (467e4dc) into master (0f04942) will increase coverage by 1.08%.
The diff coverage is 59.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #693      +/-   ##
==========================================
+ Coverage   49.27%   50.35%   +1.08%     
==========================================
  Files          23       23              
  Lines        2401     2538     +137     
==========================================
+ Hits         1183     1278      +95     
- Misses       1090     1119      +29     
- Partials      128      141      +13     
Impacted Files Coverage Δ
pkg/container/docker_run.go 1.82% <0.00%> (-0.11%) ⬇️
pkg/common/git.go 53.08% <30.15%> (-6.72%) ⬇️
pkg/model/workflow.go 30.71% <33.33%> (+5.00%) ⬆️
pkg/model/planner.go 34.56% <41.37%> (+1.48%) ⬆️
pkg/container/docker_pull.go 36.17% <64.70%> (+17.98%) ⬆️
pkg/runner/step_context.go 71.99% <71.53%> (+3.04%) ⬆️
pkg/runner/run_context.go 79.74% <94.82%> (+3.33%) ⬆️
pkg/runner/command.go 90.58% <100.00%> (+2.35%) ⬆️
pkg/runner/runner.go 76.92% <100.00%> (+0.45%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29ea8cf...467e4dc. Read the comment docs.

@mergify mergify bot requested a review from a team May 19, 2021 13:38
@mergify mergify bot merged commit 60b9606 into nektos:master May 19, 2021
@ZauberNerd ZauberNerd deleted the pull-with-auth branch May 19, 2021 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants