Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close docker client #789

Merged
merged 7 commits into from
Oct 24, 2021
Merged

Conversation

ChristopherHX
Copy link
Contributor

Please stop leaking unix sockets, it breaks my github-act-runner program.

Reference: ChristopherHX/github-act-runner#41

@mergify

This comment has been minimized.

@mergify mergify bot added the needs-work Extra attention is needed label Aug 30, 2021
@mergify

This comment has been minimized.

@codecov
Copy link

codecov bot commented Aug 30, 2021

Codecov Report

Merging #789 (7a88802) into master (0f04942) will increase coverage by 6.87%.
The diff coverage is 61.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #789      +/-   ##
==========================================
+ Coverage   49.27%   56.14%   +6.87%     
==========================================
  Files          23       23              
  Lines        2401     3751    +1350     
==========================================
+ Hits         1183     2106     +923     
- Misses       1090     1471     +381     
- Partials      128      174      +46     
Impacted Files Coverage Δ
pkg/container/docker_volume.go 0.00% <0.00%> (ø)
pkg/container/docker_run.go 5.56% <15.09%> (+3.63%) ⬆️
pkg/common/git.go 49.82% <31.81%> (-9.97%) ⬇️
pkg/model/planner.go 49.78% <42.50%> (+16.70%) ⬆️
pkg/container/docker_build.go 60.81% <57.14%> (+60.81%) ⬆️
pkg/container/docker_pull.go 35.29% <61.53%> (+17.11%) ⬆️
pkg/model/workflow.go 52.14% <63.63%> (+26.42%) ⬆️
pkg/runner/runner.go 74.46% <70.37%> (-2.01%) ⬇️
pkg/runner/expression.go 85.71% <72.09%> (-0.93%) ⬇️
pkg/runner/step_context.go 78.57% <77.15%> (+9.62%) ⬆️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8ddfca...7a88802. Read the comment docs.

@mergify
Copy link
Contributor

mergify bot commented Aug 30, 2021

@ChristopherHX this pull request has failed checks 🛠

@mergify mergify bot removed the needs-work Extra attention is needed label Aug 30, 2021
@ChristopherHX ChristopherHX marked this pull request as ready for review August 30, 2021 15:43
@ChristopherHX ChristopherHX requested a review from a team as a code owner August 30, 2021 15:43
@github-actions
Copy link
Contributor

PR is stale and will be closed in 14 days unless there is new activity

@github-actions github-actions bot added the stale label Sep 30, 2021
@mergify
Copy link
Contributor

mergify bot commented Sep 30, 2021

@ChristopherHX this pull request has failed checks 🛠

@mergify mergify bot added the needs-work Extra attention is needed label Sep 30, 2021
@ChristopherHX
Copy link
Contributor Author

I really want that act closes their docker connection or reuses it. Leaking a docker connection is bad code quality.

one tests pulls ubuntu:18.04 in arm64 which triggers the rate limit, the only reason for needs-work
while ubuntu:18.04 for native x86_64 is cached via my workflow change,

@github-actions github-actions bot removed the stale label Oct 1, 2021
@mergify mergify bot removed the needs-work Extra attention is needed label Oct 24, 2021
@mergify mergify bot requested a review from a team October 24, 2021 10:00
@mergify mergify bot merged commit 83a28d9 into nektos:master Oct 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants