-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close docker client #789
Close docker client #789
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## master #789 +/- ##
==========================================
+ Coverage 49.27% 56.14% +6.87%
==========================================
Files 23 23
Lines 2401 3751 +1350
==========================================
+ Hits 1183 2106 +923
- Misses 1090 1471 +381
- Partials 128 174 +46
Continue to review full report at Codecov.
|
@ChristopherHX this pull request has failed checks 🛠 |
PR is stale and will be closed in 14 days unless there is new activity |
@ChristopherHX this pull request has failed checks 🛠 |
I really want that act closes their docker connection or reuses it. Leaking a docker connection is bad code quality. one tests pulls ubuntu:18.04 in arm64 which triggers the rate limit, the only reason for needs-work |
Please stop leaking unix sockets, it breaks my github-act-runner program.
Reference: ChristopherHX/github-act-runner#41