Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mergify): needs-work label handling #810

Merged
merged 3 commits into from
Sep 26, 2021
Merged

Conversation

sileht
Copy link
Contributor

@sileht sileht commented Sep 10, 2021

As we can see here: #799, warn on needs-work and remove needs-work label if not needed rule are fighting each other to manage the label needs-work.

This change makes the CI list explicit, to set/unset needs-work as expected.

As we can see here: nektos#799, `warn on needs-work` and `remove needs-work label if not needed` rule are fighting each other to manage the label `needs-work`.

This change makes the CI list explicit, to set/unset `needs-work` as expected.
@sileht sileht requested a review from a team as a code owner September 10, 2021 07:44
@codecov
Copy link

codecov bot commented Sep 10, 2021

Codecov Report

Merging #810 (42ecd30) into master (0f04942) will increase coverage by 5.07%.
The diff coverage is 61.37%.

❗ Current head 42ecd30 differs from pull request most recent head dbbba0d. Consider uploading reports for the commit dbbba0d to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #810      +/-   ##
==========================================
+ Coverage   49.27%   54.34%   +5.07%     
==========================================
  Files          23       23              
  Lines        2401     3682    +1281     
==========================================
+ Hits         1183     2001     +818     
- Misses       1090     1529     +439     
- Partials      128      152      +24     
Impacted Files Coverage Δ
pkg/container/docker_build.go 0.00% <0.00%> (ø)
pkg/container/docker_run.go 2.86% <0.00%> (+0.93%) ⬆️
pkg/common/git.go 49.82% <31.81%> (-9.97%) ⬇️
pkg/runner/runner.go 70.73% <38.46%> (-5.74%) ⬇️
pkg/model/planner.go 49.78% <42.50%> (+16.70%) ⬆️
pkg/model/workflow.go 52.14% <63.63%> (+26.42%) ⬆️
pkg/container/docker_pull.go 36.36% <64.00%> (+18.18%) ⬆️
pkg/runner/expression.go 85.71% <72.09%> (-0.93%) ⬇️
pkg/runner/step_context.go 79.48% <79.05%> (+10.53%) ⬆️
pkg/runner/run_context.go 81.85% <91.08%> (+5.44%) ⬆️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1e4844...dbbba0d. Read the comment docs.

@mergify mergify bot requested a review from a team September 10, 2021 10:11
@mergify
Copy link
Contributor

mergify bot commented Sep 25, 2021

@sileht this pull request has failed checks 🛠

@mergify mergify bot added the needs-work Extra attention is needed label Sep 25, 2021
@cplee cplee merged commit a6aea44 into nektos:master Sep 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-work Extra attention is needed size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants