Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use docker lib for image ref parsing #877

Merged
merged 1 commit into from
Nov 13, 2021

Conversation

catthehacker
Copy link
Member

@catthehacker catthehacker commented Nov 13, 2021

Fixes #795

The only downside is custom URL can't be, e.g.: localhost:8000/_/ubuntu:latest

Signed-off-by: hackercat me@hackerc.at

@catthehacker catthehacker requested a review from a team as a code owner November 13, 2021 18:47
Signed-off-by: hackercat <me@hackerc.at>
@catthehacker catthehacker force-pushed the cat/fix/correct-oci-url-parsing branch from 1980ddd to faa964c Compare November 13, 2021 18:50
@codecov
Copy link

codecov bot commented Nov 13, 2021

Codecov Report

Merging #877 (faa964c) into master (0f04942) will increase coverage by 6.89%.
The diff coverage is 60.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #877      +/-   ##
==========================================
+ Coverage   49.27%   56.16%   +6.89%     
==========================================
  Files          23       25       +2     
  Lines        2401     3947    +1546     
==========================================
+ Hits         1183     2217    +1034     
- Misses       1090     1528     +438     
- Partials      128      202      +74     
Impacted Files Coverage Δ
pkg/common/outbound_ip.go 0.00% <0.00%> (ø)
pkg/container/docker_volume.go 0.00% <0.00%> (ø)
pkg/container/docker_run.go 5.56% <15.09%> (+3.63%) ⬆️
pkg/common/git.go 49.82% <31.81%> (-9.97%) ⬇️
pkg/model/planner.go 49.78% <42.50%> (+16.70%) ⬆️
pkg/container/docker_build.go 58.97% <50.00%> (+58.97%) ⬆️
pkg/container/docker_pull.go 28.35% <58.06%> (+10.17%) ⬆️
pkg/model/workflow.go 52.14% <63.63%> (+26.42%) ⬆️
pkg/artifacts/server.go 67.32% <67.32%> (ø)
pkg/runner/runner.go 74.46% <70.37%> (-2.01%) ⬇️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62d2167...faa964c. Read the comment docs.

@mergify mergify bot merged commit ec34eb9 into nektos:master Nov 13, 2021
@catthehacker catthehacker deleted the cat/fix/correct-oci-url-parsing branch November 13, 2021 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Actions Container image is misinterpreted when using own registry with short oci url
2 participants