feat: try to read ref and sha from event payload if available #889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #889 +/- ##
==========================================
+ Coverage 49.27% 57.43% +8.16%
==========================================
Files 23 30 +7
Lines 2401 4269 +1868
==========================================
+ Hits 1183 2452 +1269
- Misses 1090 1611 +521
- Partials 128 206 +78
Continue to review full report at Codecov.
|
ZauberNerd
force-pushed
the
set-ref-sha
branch
3 times, most recently
from
38ca949 to
a500d90
Compare
|
Could you add some test cases? |
ZauberNerd
force-pushed
the
set-ref-sha
branch
from
a500d90 to
80ee997
Compare
This comment has been minimized.
This comment has been minimized.
ZauberNerd
force-pushed
the
set-ref-sha
branch
from
80ee997 to
bd015ab
Compare
catthehacker
approved these changes
Jan 3, 2022
catthehacker
requested changes
Jan 3, 2022
ZauberNerd
force-pushed
the
set-ref-sha
branch
from
bd015ab to
538994c
Compare
This comment has been minimized.
This comment has been minimized.
With this change `act` will try to populate the `githubContext.ref` and `githubContext.sha` with values read from the event payload. Caveats: - `page_build` should not have a ref - `status` should not have a ref - `registry_package` should set the ref to the branch/tag but the payload isn't documented - `workflow_call` should set ref to the same value as its caller but the payload isn't documented - most of the events should set the sha to the last commit on the ref but unfortunately the sha is not always included in the payload, therefore we use the sha from the local git checkout Co-Authored-By: Philipp Hinrichsen <philipp.hinrichsen@new-work.se>
ZauberNerd
force-pushed
the
set-ref-sha
branch
from
538994c to
18c3c61
Compare
|
@catthehacker I added some tests, can you please take another look? |
KnisterPeter
approved these changes
Jan 4, 2022
catthehacker
approved these changes
Jan 6, 2022
cplee
approved these changes
Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change
actwill try to populate thegithubContext.refandgithubContext.shawith values read from the event payload.Caveats:
page_buildshould not have a refstatusshould not have a refregistry_packageshould set the ref to the branch/tag but thepayload isn't documented
workflow_callshould set ref to the same value as its caller but thepayload isn't documented
but unfortunately the sha is not always included in the payload,
therefore we use the sha from the local git checkout