Docker auth #891
Merged
Docker auth #891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ZauberNerd this pull request has failed checks 🛠 |
ZauberNerd
force-pushed
the
docker-auth
branch
from
8291d3c to
e74c857
Compare
|
@ZauberNerd this pull request has failed checks 🛠 |
ZauberNerd
force-pushed
the
docker-auth
branch
from
e74c857 to
382a5ac
Compare
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## master #891 +/- ##
==========================================
+ Coverage 49.27% 55.95% +6.68%
==========================================
Files 23 27 +4
Lines 2401 4055 +1654
==========================================
+ Hits 1183 2269 +1086
- Misses 1090 1579 +489
- Partials 128 207 +79
Continue to review full report at Codecov.
|
ZauberNerd
force-pushed
the
docker-auth
branch
from
f68cccf to
d69d5ab
Compare
Merged
catthehacker
previously approved these changes
Nov 27, 2021
cplee
previously approved these changes
Nov 27, 2021
Co-authored-by: Björn Brauer <zaubernerd@zaubernerd.de>
... the image is in a custom registry or not. Co-authored-by: Björn Brauer <zaubernerd@zaubernerd.de>
By default github actions have a docker config set with a token to pull images from docker hub. Co-authored-by: Markus Wolf <markus.wolf@new-work.se>
ZauberNerd
force-pushed
the
docker-auth
branch
from
d69d5ab to
35568b3
Compare
cplee
approved these changes
Nov 27, 2021
ZauberNerd
added a commit
to xing/act
that referenced
this pull request
Nov 30, 2021
* nektos#898 * nektos#891 have both been merged upstream, so they're no longer required here.
ZauberNerd
added a commit
to xing/act
that referenced
this pull request
Nov 30, 2021
* nektos#898 * nektos#891 have both been merged upstream, so they're no longer required here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses parts of the
docker/clito read the local docker config to get the authentication from it.This is helpful for private registries, which worked before, but required to pass
DOCKER_USERNAMEandDOCKER_PASSWORDas secrets.Now it will take existing authentication information from the Docker CLI if the secrets are not explicitly passed.